linux-kernel - Re: [PATCH] sparc64: Remove redundant __GFP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <139d8db9-1c70-4e33-9e52-a1437b7a8c87@gaisler.com>
Date: Fri, 19 Sep 2025 20:02:03 +0200
From: Andreas Larsson <andreas@...sler.com>
To: Qianfeng Rong <rongqianfeng@...o.com>,
 "David S. Miller" <davem@...emloft.net>, sparclinux@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sparc64: Remove redundant __GFP_NOWARN

On 2025-08-09 16:33, Qianfeng Rong wrote:
> Commit 16f5dfbc851b ("gfp: include __GFP_NOWARN in GFP_NOWAIT") made
> GFP_NOWAIT implicitly include __GFP_NOWARN.
> 
> Therefore, explicit __GFP_NOWARN combined with GFP_NOWAIT (e.g.,
> `GFP_NOWAIT | __GFP_NOWARN`) is now redundant.  Let's clean up these
> redundant flags across subsystems.
> 
> No functional changes.
> 
> Signed-off-by: Qianfeng Rong <rongqianfeng@...o.com>
> ---
>  arch/sparc/kernel/adi_64.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/sparc/kernel/adi_64.c b/arch/sparc/kernel/adi_64.c
> index e0e4fc527b24..18036a43cf56 100644
> --- a/arch/sparc/kernel/adi_64.c
> +++ b/arch/sparc/kernel/adi_64.c
> @@ -202,7 +202,7 @@ static tag_storage_desc_t *alloc_tag_store(struct mm_struct *mm,
>  
>  	} else {
>  		size = sizeof(tag_storage_desc_t)*max_desc;
> -		mm->context.tag_store = kzalloc(size, GFP_NOWAIT|__GFP_NOWARN);
> +		mm->context.tag_store = kzalloc(size, GFP_NOWAIT);
>  		if (mm->context.tag_store == NULL) {
>  			tag_desc = NULL;
>  			goto out;
> @@ -281,7 +281,7 @@ static tag_storage_desc_t *alloc_tag_store(struct mm_struct *mm,
>  		size = (size + (PAGE_SIZE-adi_blksize()))/PAGE_SIZE;
>  		size = size * PAGE_SIZE;
>  	}
> -	tags = kzalloc(size, GFP_NOWAIT|__GFP_NOWARN);
> +	tags = kzalloc(size, GFP_NOWAIT);
>  	if (tags == NULL) {
>  		tag_desc->tag_users = 0;
>  		tag_desc = NULL;

Reviewed-by: Andreas Larsson <andreas@...sler.com>

Picking this up to my for-next.

Thanks,
Andreas