linux-kernel - Re: [PATCH v2 3/3] dt-bindings: thermal: rockchip: tighten grf requirements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <wtwdpqi4tk3ixzmrvdyv2aguf6pjlmnz6q5gvhlajl2hk6mdys@fmkugriedhqe>
Date: Fri, 19 Sep 2025 20:35:12 +0200
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Conor Dooley <conor@...nel.org>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, 
	Daniel Lezcano <daniel.lezcano@...aro.org>, Zhang Rui <rui.zhang@...el.com>, 
	Lukasz Luba <lukasz.luba@....com>, Heiko Stuebner <heiko@...ech.de>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Robin Murphy <robin.murphy@....com>, Diederik de Haas <didi.debian@...ow.org>, 
	linux-pm@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, 
	kernel@...labora.com
Subject: Re: [PATCH v2 3/3] dt-bindings: thermal: rockchip: tighten grf
 requirements

Hi,

On Wed, Aug 20, 2025 at 08:48:23PM +0100, Conor Dooley wrote:
> On Wed, Aug 20, 2025 at 07:40:49PM +0200, Sebastian Reichel wrote:
> > Instead of having an optional rockchip,grf property, forbid using it on
> > platforms without registers in a GRF being needed for thermal monitoring
> > and make it mandatory on the platforms actually needing it.
> 
> I am assuming that "needing it" means that it was actually mandatory but
> the binding was just missing the required required entry. If so
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>

I just noticed, that I never replied: The GRF configuration is
required for proper functionality as far as I can tell. Technically
it might be skipped, if the bootloader already configured the
registers correctly. but I don't think this is something anyone wants
to rely on and with the same argument we could describe almost any
resource as optional :) The upstream kernel DT always had the GRF
specified for these platforms (and thus most likely has never been
tested without it).

Greetings,

-- Sebastian

> 
> > 
> > Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>
> > ---
> >  .../devicetree/bindings/thermal/rockchip-thermal.yaml     | 15 +++++++++++++++
> >  1 file changed, 15 insertions(+)
> > 
> > diff --git a/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml b/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
> > index 573f447cc26ed7100638277598b0e745d436fd01..9fa5c4c49d76e3a689f31797875124e7fb30d3df 100644
> > --- a/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
> > +++ b/Documentation/devicetree/bindings/thermal/rockchip-thermal.yaml
> > @@ -119,6 +119,21 @@ required:
> >    - resets
> >  
> >  allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          contains:
> > +            enum:
> > +              - rockchip,px30-tsadc
> > +              - rockchip,rk3366-tsadc
> > +              - rockchip,rk3399-tsadc
> > +              - rockchip,rk3568-tsadc
> > +    then:
> > +      required:
> > +        - rockchip,grf
> > +    else:
> > +      properties:
> > +        rockchip,grf: false
> >    - if:
> >        not:
> >          properties:
> > 
> > -- 
> > 2.50.1
> > 



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)