linux-kernel - Re: [PATCH 1/2] pinctrl: qcom: glymur: Drop unnecessary platform data from match table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4o3t43wu4vvza3suzzinzhjc2beign73bbqjq7rq5yoicsdtng@mte5isu7mpja>
Date: Fri, 19 Sep 2025 21:37:07 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Abel Vesa <abel.vesa@...aro.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Pankaj Patil <pankaj.patil@....qualcomm.com>,
        Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        linux-arm-msm@...r.kernel.org, linux-gpio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] pinctrl: qcom: glymur: Drop unnecessary platform
 data from match table

On Fri, Sep 19, 2025 at 03:17:11PM +0300, Abel Vesa wrote:
> The platform specific configuration is already passed on to the generic
> msm probe. So it's useless to exist in the match table next to the
> compatible. So drop it from match table.
> 
> Fixes: 87ebcd8baebf ("pinctrl: qcom: Add glymur pinctrl driver")

No need for this tag.

Other than that:


Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>



> Signed-off-by: Abel Vesa <abel.vesa@...aro.org>
> ---
>  drivers/pinctrl/qcom/pinctrl-glymur.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/qcom/pinctrl-glymur.c b/drivers/pinctrl/qcom/pinctrl-glymur.c
> index 9913f98e953110d32e804c8d210220857583ba46..9781e7fcb3a11c85dbd5497170188e2da051215b 100644
> --- a/drivers/pinctrl/qcom/pinctrl-glymur.c
> +++ b/drivers/pinctrl/qcom/pinctrl-glymur.c
> @@ -1743,7 +1743,7 @@ static const struct msm_pinctrl_soc_data glymur_tlmm = {
>  };
>  
>  static const struct of_device_id glymur_tlmm_of_match[] = {
> -	{ .compatible = "qcom,glymur-tlmm", .data = &glymur_tlmm },
> +	{ .compatible = "qcom,glymur-tlmm", },
>  	{ }
>  };
>  
> 
> -- 
> 2.48.1
> 

-- 
With best wishes
Dmitry