linux-kernel - Re: [PATCH v1] cpufreq: Add defensive checks during driver registration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0hgku5V-3GNVH2w8GT2JzkHOU2NZkfHdrRDT-Hb80tuuQ@mail.gmail.com>
Date: Fri, 19 Sep 2025 23:13:03 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Zihuan Zhang <zhangzihuan@...inos.cn>
Cc: "Rafael J . wysocki" <rafael@...nel.org>, Viresh Kumar <viresh.kumar@...aro.org>, 
	zhenglifeng <zhenglifeng1@...wei.com>, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] cpufreq: Add defensive checks during driver registration

On Mon, Sep 8, 2025 at 10:57 AM Zihuan Zhang <zhangzihuan@...inos.cn> wrote:
>
> Currently, cpufreq allows drivers to implement both has_target() and
> has_target_index(), which can lead to ambiguous or incorrect behavior.
>
> This patch adds defensive checks in the driver registration path to
> prevent invalid implementations. For example, a driver is no longer
> allowed to implement both has_target() and has_target_index() at the
> same time. These checks help catch driver mistakes early and improve
> overall robustness, without affecting existing valid drivers.
>
> Signed-off-by: Zihuan Zhang <zhangzihuan@...inos.cn>
> ---
>  drivers/cpufreq/cpufreq.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index a615c98d80ca..cead6d4fa1ad 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -2922,6 +2922,7 @@ int cpufreq_register_driver(struct cpufreq_driver *driver_data)
>                 return -EPROBE_DEFER;
>
>         if (!driver_data || !driver_data->verify || !driver_data->init ||
> +            (driver_data->target_index && driver_data->target) ||
>              (!!driver_data->setpolicy == (driver_data->target_index || driver_data->target)) ||
>              (!driver_data->get_intermediate != !driver_data->target_intermediate) ||
>              (!driver_data->online != !driver_data->offline) ||
> --

Applied as 6.18 material with edits in the subject and changelog, thanks!