linux-kernel - Re: [PATCH v2] arm64: dts: qcom: sdm845-shift-axolotl: Fix typo of compatible

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <4ae418ec-5b84-40b5-b47f-ee2e988d7e99@joelselvaraj.com>
Date: Fri, 19 Sep 2025 06:23:27 +0000
From: Joel Selvaraj <foss@...lselvaraj.com>
To: Luca Weiss <luca.weiss@...rphone.com>, Tamura Dai <kirinode0@...il.com>, Bjorn Andersson <andersson@...nel.org>, Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Joel Selvaraj <joelselvaraj.oss@...il.com>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2] arm64: dts: qcom: sdm845-shift-axolotl: Fix typo of compatible

Hi Luca Weiss and Tamura Dai,

On 9/12/25 02:24, Luca Weiss wrote:
> Hi Tamura,
> 
> On Fri Sep 12, 2025 at 9:01 AM CEST, Tamura Dai wrote:
>> The bug is a typo in the compatible string for the touchscreen node.
>> According to Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml,
>> the correct compatible is "focaltech,ft8719", but the device tree used
>> "focaltech,fts8719".
> 
> +Joel
> 
> I don't think this patch is really correct, in the sdm845-mainline fork
> there's a different commit which has some more changes to make the
> touchscreen work:
> 
> https://gitlab.com/sdm845-mainline/linux/-/commit/2ca76ac2e046158814b043fd4e37949014930d70

Yes, this patch is not correct. My commit from the gitlab repo is the 
correct one. But I personally don't have the shiftmq6 device to smoke 
test before sending the patch. That's why I was hesitant to send it 
upstream. I have now requested someone to confirm if the touchscreen 
works with my gitlab commit. If if its all good, I will send the correct 
patch later.

Regards,
Joel