linux-kernel - Re: [PATCH] mm/show_mem: update printk/pr_info messages and replace legacy printk(KERN_CONT ...) with pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e8121724-a436-47d5-af3a-a16f81cd0649@suse.cz>
Date: Fri, 19 Sep 2025 08:46:05 +0200
From: Vlastimil Babka <vbabka@...e.cz>
To: Manish Kumar <manish1588@...il.com>, akpm@...ux-foundation.org
Cc: surenb@...gle.com, mhocko@...e.com, jackmanb@...gle.com,
 hannes@...xchg.org, ziy@...dia.com, linux-mm@...ck.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/show_mem: update printk/pr_info messages and replace
 legacy printk(KERN_CONT ...) with pr_cont()

Changelog should not be empty even for trivial patches.

On 9/18/25 20:14, Manish Kumar wrote:
> Signed-off-by: Manish Kumar <manish1588@...il.com>

This changes 2 of X in the file. Why only these 2? And no, I'm not
encouraging to resend with a full file changes. We do these modernizations
to new APIs only while changing the code for other reasons, not separately,
if there's nothing wrong otherwise with the legacy api. The churn isn't
worth it.

> ---
>  mm/show_mem.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/mm/show_mem.c b/mm/show_mem.c
> index 0cf8bf5d832d..798949d10ce1 100644
> --- a/mm/show_mem.c
> +++ b/mm/show_mem.c
> @@ -26,7 +26,7 @@ unsigned long totalcma_pages __read_mostly;
>  static inline void show_node(struct zone *zone)
>  {
>  	if (IS_ENABLED(CONFIG_NUMA))
> -		printk("Node %d ", zone_to_nid(zone));
> +		pr_info("Node %d ", zone_to_nid(zone));
>  }
>  
>  long si_mem_available(void)
> @@ -156,7 +156,7 @@ static void show_migration_types(unsigned char type)
>  	}
>  
>  	*p = '\0';
> -	printk(KERN_CONT "(%s) ", tmp);
> +	pr_cont("(%s) ", tmp);
>  }
>  
>  static bool node_has_managed_zones(pg_data_t *pgdat, int max_zone_idx)