linux-kernel - Re: [PATCH] staging: gpib: enclose macro values in parentheses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aM0N1aZYErdXsOAc@stanley.mountain>
Date: Fri, 19 Sep 2025 11:01:25 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Soumya Ranjan Patnaik <soumyaranjan1812@...il.com>
Cc: dpenkler@...il.com, gregkh@...uxfoundation.org,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: gpib: enclose macro values in parentheses

On Fri, Sep 19, 2025 at 12:33:48PM +0530, Soumya Ranjan Patnaik wrote:
> Macros with complex values should be enclosed in parentheses to avoid
> unexpected behavior due to operator precedence or macro expansion issues.
> This change wraps the LINVAL macro values in parentheses to comply with
> kernel coding style and improve code safety.
> 
> Signed-off-by: Soumya Ranjan Patnaik <soumyaranjan1812@...il.com>

That's going to break the build.

https://lore.kernel.org/all/?q=LINVAL

regards,
dan carpenter