linux-kernel - Re: [PATCH 02/21] add definitions for BLKTRACESETUP2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <79911e5b-0abc-4cd5-b890-15008bbc7f84@wdc.com>
Date: Fri, 19 Sep 2025 08:10:17 +0000
From: Johannes Thumshirn <Johannes.Thumshirn@....com>
To: Chaitanya Kulkarni <chaitanyak@...dia.com>, Jens Axboe <axboe@...nel.dk>
CC: Steven Rostedt <rostedt@...dmis.org>, Masami Hiramatsu
	<mhiramat@...nel.org>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	"linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-trace-kernel@...r.kernel.org" <linux-trace-kernel@...r.kernel.org>,
	"linux-btrace@...r.kernel.org" <linux-btrace@...r.kernel.org>, John Garry
	<john.g.garry@...cle.com>, Hannes Reinecke <hare@...e.de>, Damien Le Moal
	<dlemoal@...nel.org>, hch <hch@....de>, Naohiro Aota <Naohiro.Aota@....com>,
	Shinichiro Kawasaki <shinichiro.kawasaki@....com>, "Martin K . Petersen"
	<martin.petersen@...cle.com>
Subject: Re: [PATCH 02/21] add definitions for BLKTRACESETUP2

On 9/19/25 9:53 AM, Chaitanya Kulkarni wrote:
> On 9/9/25 04:07, Johannes Thumshirn wrote:
>> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@....com>
>> ---
>>    blktrace_api.h | 15 +++++++++++++++
>>    1 file changed, 15 insertions(+)
>>
>> diff --git a/blktrace_api.h b/blktrace_api.h
>> index 172b4c2..9f435a5 100644
>> --- a/blktrace_api.h
>> +++ b/blktrace_api.h
>> @@ -139,9 +139,24 @@ struct blk_user_trace_setup {
>>    	__u32 pid;
>>    };
>>    
>> +/*
>> + * User setup structure passed with BLKTRACESETUP2
>> + */
>> +struct blk_user_trace_setup2 {
>> +	char name[32];			/* output */
>> +	__u64 act_mask;			/* input */
>> +	__u32 buf_size;			/* input */
>> +	__u32 buf_nr;			/* input */
>> +	__u64 start_lba;
>> +	__u64 end_lba;
>> +	__u32 pid;
>> +	__u32 reserved;			/* for futute use */
>> +};
>> +
>>    #define BLKTRACESETUP _IOWR(0x12,115,struct blk_user_trace_setup)
>>    #define BLKTRACESTART _IO(0x12,116)
>>    #define BLKTRACESTOP _IO(0x12,117)
>>    #define BLKTRACETEARDOWN _IO(0x12,118)
>> +#define BLKTRACESETUP2 _IOWR(0x12, 142, struct blk_user_trace_setup2)
>>    
>>    #endif
> This definitely needs a commit log explaining why you need setup2 struct and
> what kind of problem it is solving.

Whoopsie, you're 100% right!