linux-kernel - Re: [PATCH RFC] thunderbolt: Re-add DP resources on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250919084121.GP2912318@black.igk.intel.com>
Date: Fri, 19 Sep 2025 10:41:21 +0200
From: Mika Westerberg <mika.westerberg@...ux.intel.com>
To: 李佳怡 <lijiayi@...inos.cn>
Cc: linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFC] thunderbolt: Re-add DP resources on resume

On Fri, Sep 19, 2025 at 04:00:48PM +0800, 李佳怡 wrote:
> > The lspci dump indicates this is ASMedia host controller. I did not even
> > know that they have such thing. I thought they only have device (which
> > should be working in Linux). The host side may require some additional
> > enablement.
> 
> Apologies, Please find the latest results.
> 
> # tbdump -vv -r 0 -N 1  -a 10 ADP_CS_5
> 0x0005 0x0000d809 0b00000000 00000000 11011000 00001001 .... ADP_CS_5
>   [00:06]        0x9 Max Input HopID
>   [11:17]       0x1b Max Output HopID
>   [22:28]        0x0 Link Credits Allocated
>   [29:29]        0x0 HEC Error Enable (HEE)
>   [30:30]        0x0 Flow Control Error Enable (FCEE)
>   [31:31]        0x0 Disable Hot Plug Events (DHP)
> 
> # tbdump -vv -r 0 -N 1  -a 11 ADP_CS_5
> 0x0005 0x0000d809 0b00000000 00000000 11011000 00001001 .... ADP_CS_5
>   [00:06]        0x9 Max Input HopID
>   [11:17]       0x1b Max Output HopID
>   [22:28]        0x0 Link Credits Allocated
>   [29:29]        0x0 HEC Error Enable (HEE)
>   [30:30]        0x0 Flow Control Error Enable (FCEE)
>   [31:31]        0x0 Disable Hot Plug Events (DHP)

Thanks! DHP bits are not set as expected.

> Regarding the ASMedia host controller: if hotplug events for the DP IN
> adapter are not being generated, is it feasible to manually add the DP IN
> resource as I initially thought, or is that approach incorrect for this
> scenario?

Well the host router exits sleep (runtime resume) and once it is being
enumerated again by the driver it is expected to send the plug events to
the DP IN adapters according to the spec. I prefer not to add things like
these if there is a standard way. Are you associated with ASMedia or you
just have a machine that has this controller? If you are then is there
possibility to talk to the hardware folks and ask if this is known issue or
perhaps it has some older firmware? I definitely like to get this working
but we should first figure out if this is some sort of known issue perhaps?