linux-kernel - Re: [PATCH v3 6/8] dt-bindings: soc: renesas: Add the Renesas RZ/N1 GPIO Interrupt Multiplexer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aM0ju74JJbjliQAl@ninjato>
Date: Fri, 19 Sep 2025 11:34:51 +0200
From: Wolfram Sang <wsa+renesas@...g-engineering.com>
To: "Herve Codina (Schneider Electric)" <herve.codina@...tlin.com>
Cc: Thomas Gleixner <tglx@...utronix.de>,
	Hoan Tran <hoan@...amperecomputing.com>,
	Linus Walleij <linus.walleij@...aro.org>,
	Bartosz Golaszewski <brgl@...ev.pl>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Geert Uytterhoeven <geert+renesas@...der.be>,
	Magnus Damm <magnus.damm@...il.com>,
	Saravana Kannan <saravanak@...gle.com>,
	Serge Semin <fancer.lancer@...il.com>,
	Phil Edworthy <phil.edworthy@...esas.com>,
	linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org,
	Pascal Eberhard <pascal.eberhard@...com>,
	Miquel Raynal <miquel.raynal@...tlin.com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v3 6/8] dt-bindings: soc: renesas: Add the Renesas RZ/N1
 GPIO Interrupt Multiplexer


> +  interrupt-map:
> +    description:
> +      Specifies the mapping from external GPIO interrupt lines to the output
> +      interrupts. The array items have to be ordered with the first item
> +      related to the output line 0 (IRQ 103), the next one to the output line 1
> +      (IRQ 104) and so on up to the output line 8 (IRQ 110).

maxItems 8?

> +        /*
> +         * The child interrupt number is computed using the following formula:
> +         *    gpio_bank * 32 + gpio_number
> +         *
> +         * with:
> +         *    - gpio_bank: The GPIO bank number
> +         *          - 0 for GPIO0A,
> +         *          - 1 for GPIO1A,
> +         *          - 2 for GPIO2A
> +         *    - gpio_number: Number of the gpio in the bank (0..31)
> +         */

I wonder if this comment wouldn't be better in the interrupt-map
description above?


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)