linux-kernel - Re: [PATCH v3 1/6] KVM: SVM: Move x2AVIC MSR interception helper to avic.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <34dkuvu3s47ypxivxaqeyxdvgia6npjiw7b43mkvciqmngra4h@5hl5y7fzcyv5>
Date: Fri, 19 Sep 2025 15:05:08 +0530
From: Naveen N Rao <naveen@...nel.org>
To: Sean Christopherson <seanjc@...gle.com>
Cc: Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 1/6] KVM: SVM: Move x2AVIC MSR interception helper to
 avic.c

On Thu, Sep 18, 2025 at 05:21:31PM -0700, Sean Christopherson wrote:
> Move svm_set_x2apic_msr_interception() to avic.c as it's only relevant
> when x2AVIC is enabled/supported and only called by AVIC code.  In
> addition to scoping AVIC code to avic.c, this will allow burying the
> global x2avic_enabled variable in avic.
> 
> Opportunistically rename the helper to explicitly scope it to "avic".
> 
> No functional change intended.
> 
> Signed-off-by: Sean Christopherson <seanjc@...gle.com>
> ---
>  arch/x86/kvm/svm/avic.c | 57 ++++++++++++++++++++++++++++++++++++++---
>  arch/x86/kvm/svm/svm.c  | 49 -----------------------------------
>  arch/x86/kvm/svm/svm.h  |  1 -
>  3 files changed, 54 insertions(+), 53 deletions(-)

Reviewed-by: Naveen N Rao (AMD) <naveen@...nel.org>

- Naveen