linux-kernel - Re: [PATCH] arm: gen-mach-types: don't include absolute filename

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1159aa58f8a0ab69f9327a98ae3fbb973f6ee36d.camel@pengutronix.de>
Date: Fri, 19 Sep 2025 11:46:59 +0200
From: Lucas Stach <l.stach@...gutronix.de>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: linux-arm-kernel@...ts.infradead.org, kernel@...gutronix.de, 
	linux-kernel@...r.kernel.org, Marco Felsch <m.felsch@...gutronix.de>
Subject: Re: [PATCH] arm: gen-mach-types: don't include absolute filename

Hi Russell,

can I ask you to kindly reconsider this patch? The generated header
ends up in various packages, not just in compiled form where the
comment wouldn't matter, but also in its raw source code form.

For embedded build systems this mostly affects the debug packages that
carry the full source code. More general purpose distributions like
debian ship this file in the linux-headers package as it's part of the
kapi and they want to allow out-of-tree module builds with the header
package. All those distributions have to jump through various hoops to
make those header packages reproducible, while this patch would be an
easy fix from the kernel side.

I don't think the input file name carries any real value for any of the
users of this header. Especially now where mach-types is essentially
static, with no substantial changes in the last 8 years.

Best regards,
Lucas

Am Donnerstag, dem 14.11.2024 um 14:00 +0100 schrieb Marco Felsch:
> Don't include the abosulte filename into the generated mach-types.h
> header and instead make use of arm64 note. The motivation for this
> change is Yocto emitting a build warning:
> 
> > File /usr/src/debug/linux-raspberrypi/6.11.7/arch/arm/include/generated/asm/mach-types.h in package linux-raspberrypi-src contains reference to TMPDIR [buildpaths]
> 
> So this change brings us one step closer to make the build result
> reproducible independent of the build path.
> 
> Signed-off-by: Marco Felsch <m.felsch@...gutronix.de>
> ---
>  arch/arm/tools/gen-mach-types | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/arch/arm/tools/gen-mach-types b/arch/arm/tools/gen-mach-types
> index cbe1c33bb871..fdc4805b9d98 100644
> --- a/arch/arm/tools/gen-mach-types
> +++ b/arch/arm/tools/gen-mach-types
> @@ -24,8 +24,7 @@ NF == 3 {
>  
>  END	{
>  	  printf("/*\n");
> -	  printf(" * This was automagically generated from %s!\n", FILENAME);
> -	  printf(" * Do NOT edit\n");
> +	  printf(" * Generated file - do not edit\n");
>  	  printf(" */\n\n");
>  	  printf("#ifndef __ASM_ARM_MACH_TYPE_H\n");
>  	  printf("#define __ASM_ARM_MACH_TYPE_H\n\n");