linux-kernel - Re: [PATCH v5 04/19] x86: Add arch specific kasan functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <tiuv6fwtmktlibyvsvixlla6zpjikrw5zfnlv4jzq343haro46@boagnya3rx47>
Date: Fri, 19 Sep 2025 13:05:02 +0200
From: Maciej Wieczor-Retman <maciej.wieczor-retman@...el.com>
To: Andrey Ryabinin <ryabinin.a.a@...il.com>
CC: <sohil.mehta@...el.com>, <baohua@...nel.org>, <david@...hat.com>,
	<kbingham@...nel.org>, <weixugc@...gle.com>, <Liam.Howlett@...cle.com>,
	<alexandre.chartre@...cle.com>, <kas@...nel.org>, <mark.rutland@....com>,
	<trintaeoitogc@...il.com>, <axelrasmussen@...gle.com>, <yuanchu@...gle.com>,
	<joey.gouly@....com>, <samitolvanen@...gle.com>, <joel.granados@...nel.org>,
	<graf@...zon.com>, <vincenzo.frascino@....com>, <kees@...nel.org>,
	<ardb@...nel.org>, <thiago.bauermann@...aro.org>, <glider@...gle.com>,
	<thuth@...hat.com>, <kuan-ying.lee@...onical.com>,
	<pasha.tatashin@...een.com>, <nick.desaulniers+lkml@...il.com>,
	<vbabka@...e.cz>, <kaleshsingh@...gle.com>, <justinstitt@...gle.com>,
	<catalin.marinas@....com>, <alexander.shishkin@...ux.intel.com>,
	<samuel.holland@...ive.com>, <dave.hansen@...ux.intel.com>, <corbet@....net>,
	<xin@...or.com>, <dvyukov@...gle.com>, <tglx@...utronix.de>,
	<scott@...amperecomputing.com>, <jason.andryuk@....com>, <morbo@...gle.com>,
	<nathan@...nel.org>, <lorenzo.stoakes@...cle.com>, <mingo@...hat.com>,
	<brgerst@...il.com>, <kristina.martsenko@....com>, <bigeasy@...utronix.de>,
	<luto@...nel.org>, <jgross@...e.com>, <jpoimboe@...nel.org>,
	<urezki@...il.com>, <mhocko@...e.com>, <ada.coupriediaz@....com>,
	<hpa@...or.com>, <leitao@...ian.org>, <peterz@...radead.org>,
	<wangkefeng.wang@...wei.com>, <surenb@...gle.com>, <ziy@...dia.com>,
	<smostafa@...gle.com>, <ubizjak@...il.com>, <jbohac@...e.cz>,
	<broonie@...nel.org>, <akpm@...ux-foundation.org>,
	<guoweikang.kernel@...il.com>, <rppt@...nel.org>, <pcc@...gle.com>,
	<jan.kiszka@...mens.com>, <nicolas.schier@...ux.dev>, <will@...nel.org>,
	<andreyknvl@...il.com>, <jhubbard@...dia.com>, <bp@...en8.de>,
	<x86@...nel.org>, <linux-doc@...r.kernel.org>, <linux-mm@...ck.org>,
	<llvm@...ts.linux.dev>, <linux-kbuild@...r.kernel.org>,
	<kasan-dev@...glegroups.com>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v5 04/19] x86: Add arch specific kasan functions

On 2025-09-18 at 17:52:39 +0200, Andrey Ryabinin wrote:
>
>On 8/25/25 10:24 PM, Maciej Wieczor-Retman wrote:
>
>> +static inline void *__tag_set(const void *__addr, u8 tag)
>> +{
>> +	u64 addr = (u64)__addr;
>> +
>> +	addr &= ~__tag_shifted(KASAN_TAG_MASK);
>> +	addr |= __tag_shifted(tag);
>> +
>> +	return (void *)addr;
>> +}
>> +
>
>
>This requires some ifdef magic to avoid getting this into vdso32 image build process,
>otherwise we'll get this warning:
>
>CC      arch/x86/entry/vdso/vdso32/vclock_gettime.o
>In file included from ../arch/x86/include/asm/page.h:10,
>                 from ../arch/x86/include/asm/processor.h:20,
>                 from ../arch/x86/include/asm/timex.h:5,
>                 from ../include/linux/timex.h:67,
>                 from ../include/linux/time32.h:13,
>                 from ../include/linux/time.h:60,
>                 from ../arch/x86/entry/vdso/vdso32/../vclock_gettime.c:11,
>                 from ../arch/x86/entry/vdso/vdso32/vclock_gettime.c:4:
>../arch/x86/include/asm/kasan.h: In function ‘__tag_set’:
>../arch/x86/include/asm/kasan.h:81:20: warning: cast from pointer to integer of different size [-Wpointer-to-int-cast]
>   81 |         u64 addr = (u64)__addr;
>      |                    ^
>../arch/x86/include/asm/kasan.h:86:16: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>   86 |         return (void *)addr;
>      |                ^
>

Thanks for noticing that, I'll fix it :)

-- 
Kind regards
Maciej Wieczór-Retman