linux-kernel - Re: [PATCH] pid: use ns_capable_noaudit() when determining net sysctl permissions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250919-gaswerk-auffressen-168545629187@brauner>
Date: Fri, 19 Sep 2025 13:08:58 +0200
From: Christian Brauner <brauner@...nel.org>
To: linux-kernel@...r.kernel.org,
	Christian Göttsche <cgoettsche@...tendoof.de>
Cc: Christian Brauner <brauner@...nel.org>,
	Christian Göttsche <cgzones@...glemail.com>,
	linux-security-module@...r.kernel.org,
	selinux@...r.kernel.org
Subject: Re: [PATCH] pid: use ns_capable_noaudit() when determining net sysctl permissions

On Wed, 10 Sep 2025 21:26:05 +0200, Christian Göttsche wrote:
> The capability check should not be audited since it is only being used
> to determine the inode permissions. A failed check does not indicate a
> violation of security policy but, when an LSM is enabled, a denial audit
> message was being generated.
> 
> The denial audit message can either lead to the capability being
> unnecessarily allowed in a security policy, or being silenced potentially
> masking a legitimate capability check at a later point in time.
> 
> [...]

Applied to the vfs-6.18.misc branch of the vfs/vfs.git tree.
Patches in the vfs-6.18.misc branch should appear in linux-next soon.

Please report any outstanding bugs that were missed during review in a
new review to the original patch series allowing us to drop it.

It's encouraged to provide Acked-bys and Reviewed-bys even though the
patch has now been applied. If possible patch trailers will be updated.

Note that commit hashes shown below are subject to change due to rebase,
trailer updates or similar. If in doubt, please check the listed branch.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git
branch: vfs-6.18.misc

[1/1] pid: use ns_capable_noaudit() when determining net sysctl permissions
      https://git.kernel.org/vfs/vfs/c/b9cb7e59ac4a