linux-kernel - Re: [PATCH RFC v2 18/20] drm/vkms: Prepare pre_blend_color

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0f63d9e1-8ef6-4d1d-83dc-6666a256f81b@bootlin.com>
Date: Fri, 19 Sep 2025 14:48:18 +0200
From: Louis Chauvet <louis.chauvet@...tlin.com>
To: Nícolas F. R. A. Prado <nfraprado@...labora.com>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 Chun-Kuang Hu <chunkuang.hu@...nel.org>,
 Philipp Zabel <p.zabel@...gutronix.de>,
 Matthias Brugger <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Haneen Mohammed <hamohammed.sa@...il.com>,
 Melissa Wen <melissa.srw@...il.com>
Cc: Alex Hung <alex.hung@....com>, wayland-devel@...ts.freedesktop.org,
 harry.wentland@....com, leo.liu@....com, ville.syrjala@...ux.intel.com,
 pekka.paalanen@...labora.com, contact@...rsion.fr, mwen@...lia.com,
 jadahl@...hat.com, sebastian.wick@...hat.com, shashank.sharma@....com,
 agoins@...dia.com, joshua@...ggi.es, mdaenzer@...hat.com, aleixpol@....org,
 xaver.hugl@...il.com, victoria@...tem76.com, uma.shankar@...el.com,
 quic_naseer@...cinc.com, quic_cbraga@...cinc.com, quic_abhinavk@...cinc.com,
 marcan@...can.st, Liviu.Dudau@....com, sashamcintosh@...gle.com,
 chaitanya.kumar.borah@...el.com, mcanal@...lia.com, kernel@...labora.com,
 daniels@...labora.com, leandro.ribeiro@...labora.com,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 linux-mediatek@...ts.infradead.org, linux-arm-kernel@...ts.infradead.org,
 Simona Vetter <simona.vetter@...ll.ch>
Subject: Re: [PATCH RFC v2 18/20] drm/vkms: Prepare
 pre_blend_color_transform() for post-blend pipelines

Le 18/09/2025 à 02:43, Nícolas F. R. A. Prado a écrit :
> As a preparatory step for supporting post-blend color pipelines in VKMS,
> rename pre_blend_color_transform() to color_transform() and make it take
> the first colorop instead of a plane state, so it can be shared by both
> pre- and post-blend color pipeline code paths.
> 
> Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>

Reviewed-by: Louis Chauvet <louis.chauvet@...tlin.com>

> ---
>   drivers/gpu/drm/vkms/vkms_composer.c | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/vkms/vkms_composer.c b/drivers/gpu/drm/vkms/vkms_composer.c
> index 31b1dd3cd115d930ec3ed498403a8f44208d76c3..05e1551d6330e4dc14563d3a399b3544d11c6576 100644
> --- a/drivers/gpu/drm/vkms/vkms_composer.c
> +++ b/drivers/gpu/drm/vkms/vkms_composer.c
> @@ -189,13 +189,13 @@ static void apply_colorop(struct pixel_argb_s32 *pixel, struct drm_colorop *colo
>   	}
>   }
>   
> -static void pre_blend_color_transform(const struct vkms_plane_state *plane_state,
> -				      struct line_buffer *output_buffer)
> +static void color_transform(struct drm_colorop *first_colorop,
> +			    struct line_buffer *output_buffer)
>   {
>   	struct pixel_argb_s32 pixel;
>   
>   	for (size_t x = 0; x < output_buffer->n_pixels; x++) {
> -		struct drm_colorop *colorop = plane_state->base.base.color_pipeline;
> +		struct drm_colorop *colorop = first_colorop;
>   
>   		/*
>   		 * Some operations, such as applying a BT709 encoding matrix,
> @@ -449,7 +449,7 @@ static void blend_line(struct vkms_plane_state *current_plane, int y,
>   	 */
>   	current_plane->pixel_read_line(current_plane, src_x_start, src_y_start, direction,
>   				       pixel_count, &stage_buffer->pixels[dst_x_start]);
> -	pre_blend_color_transform(current_plane, stage_buffer);
> +	color_transform(current_plane->base.base.color_pipeline, stage_buffer);
>   	pre_mul_alpha_blend(stage_buffer, output_buffer,
>   			    dst_x_start, pixel_count);
>   }
> 

-- 
--
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com