linux-kernel - Re: [PATCH net-next v3] selftests: forwarding: Reorder (ar)ping arguments to obey POSIX getopt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87frcimvhg.fsf@nvidia.com>
Date: Fri, 19 Sep 2025 15:12:08 +0200
From: Petr Machata <petrm@...dia.com>
To: David Yang <mmyangfl@...il.com>
CC: <netdev@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>, "Eric
 Dumazet" <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>, Simon Horman <horms@...nel.org>, Shuah Khan
	<shuah@...nel.org>, Petr Machata <petrm@...dia.com>, Amit Cohen
	<amcohen@...dia.com>, Li Shuang <shuali@...hat.com>, Alessandro Zanni
	<alessandro.zanni87@...il.com>, Hangbin Liu <liuhangbin@...il.com>,
	<linux-kselftest@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH net-next v3] selftests: forwarding: Reorder (ar)ping
 arguments to obey POSIX getopt


David Yang <mmyangfl@...il.com> writes:

> Quoted from musl wiki:
>
>   GNU getopt permutes argv to pull options to the front, ahead of
>   non-option arguments. musl and the POSIX standard getopt stop
>   processing options at the first non-option argument with no
>   permutation.
>
> Thus these scripts stop working on musl since non-option arguments for
> tools using getopt() (in this case, (ar)ping) do not always come last.
> Fix it by reordering arguments.
>
> Signed-off-by: David Yang <mmyangfl@...il.com>

Reviewed-by: Petr Machata <petrm@...dia.com>