linux-kernel - Re: [PATCH] lib/crypto: Add SHA3-224, SHA3-256, SHA3-384, SHA-512, SHAKE128, SHAKE256

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2df4e63a5c34354ebeb6603f81a662380517fbc4.camel@redhat.com>
Date: Fri, 19 Sep 2025 09:59:21 -0400
From: Simo Sorce <simo@...hat.com>
To: David Howells <dhowells@...hat.com>, Stephan Müller
	 <smueller@...onox.de>
Cc: Eric Biggers <ebiggers@...nel.org>, "Jason A. Donenfeld"
 <Jason@...c4.com>,  Ard Biesheuvel	 <ardb@...nel.org>, Herbert Xu
 <herbert@...dor.apana.org.au>, 	linux-crypto@...r.kernel.org,
 keyrings@...r.kernel.org, 	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] lib/crypto: Add SHA3-224, SHA3-256, SHA3-384, SHA-512,
 SHAKE128, SHAKE256

On Fri, 2025-09-19 at 07:17 +0100, David Howells wrote:
> Stephan Müller <smueller@...onox.de> wrote:
> 
> > For a multi-stage squeeze, it is perhaps not helpful to zeroize the context 
> > here.
> 
> Yeah - I've seen this now that I'm starting to trawl through your dilithium
> code, so it will need adjusting.


I strongly suggest creating a test vector where multiple absorb and
squeeze operations are done in intermixed order, and then use that test
vector in your Kunit tests to ensure changes to the code do not break
this fundamental property of the keccak sponge algorithm.

Simo.

-- 
Simo Sorce
Distinguished Engineer
RHEL Crypto Team
Red Hat, Inc