linux-kernel - Re: [PATCH v3 8/8] ARM: dts: r9a06g032: Add support for GPIO interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250919155910.4d106256@bootlin.com>
Date: Fri, 19 Sep 2025 15:59:10 +0200
From: Herve Codina <herve.codina@...tlin.com>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc: Thomas Gleixner <tglx@...utronix.de>, Hoan Tran
 <hoan@...amperecomputing.com>, Linus Walleij <linus.walleij@...aro.org>,
 Bartosz Golaszewski <brgl@...ev.pl>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Geert Uytterhoeven <geert+renesas@...der.be>, Magnus
 Damm <magnus.damm@...il.com>, Saravana Kannan <saravanak@...gle.com>, Serge
 Semin <fancer.lancer@...il.com>, Phil Edworthy <phil.edworthy@...esas.com>,
 linux-gpio@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org, Pascal
 Eberhard <pascal.eberhard@...com>, Miquel Raynal
 <miquel.raynal@...tlin.com>, Thomas Petazzoni
 <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v3 8/8] ARM: dts: r9a06g032: Add support for GPIO
 interrupts

On Fri, 19 Sep 2025 11:42:46 +0200
Wolfram Sang <wsa+renesas@...g-engineering.com> wrote:

> > +			/*
> > +			 * interrupt-map has to be updated according to GPIO
> > +			 * usage. The order has to be kept. Only the src irq
> > +			 * (0 field) has to be updated with the needed GPIO
> > +			 * interrupt number.
> > +			 */
> > +			interrupt-map = <0 &gic GIC_SPI 103 IRQ_TYPE_LEVEL_HIGH>,
> > +					<0 &gic GIC_SPI 104 IRQ_TYPE_LEVEL_HIGH>,
> > +					<0 &gic GIC_SPI 105 IRQ_TYPE_LEVEL_HIGH>,
> > +					<0 &gic GIC_SPI 106 IRQ_TYPE_LEVEL_HIGH>,
> > +					<0 &gic GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>,
> > +					<0 &gic GIC_SPI 108 IRQ_TYPE_LEVEL_HIGH>,
> > +					<0 &gic GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>,
> > +					<0 &gic GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>;  
> 
> I'd think this should be dropped from the include and added in the board
> file instead. I did this with my board and it works fine.
> 

I can only reduce the table but I need to keep the interrupt-map property.

'interrupt-map' is a required property. If the board doesn't use any interrupt
GPIO, its dts has no reason to set the interrupt-map.

In that case, if I fully remove 'interrupt-map' in the dtsi, dtbs_check
will not be happy. Indeed, a required property is missing.

Also, having the full table containing the 8 items with the correct GIC
interrupt number and the correct order could help a user to route the
GPIO line to one of those 8 items.

The '0' field use as interrupt source matches the registers reset value
of the irq-mux controller.

With that in mind, do you still think that I should reduce this table?

Best regards,
Hervé