linux-kernel - Re: [PATCH v4 2/7] nvmem: qcom-spmi-sdam: Migrate to devm_spmi_subdevice_alloc_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025091925-thirsting-underuse-14ab@gregkh>
Date: Fri, 19 Sep 2025 15:59:32 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Uwe Kleine-König <u.kleine-koenig@...libre.com>,
	Andy Shevchenko <andy.shevchenko@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	sboyd@...nel.org, jic23@...nel.org, dlechner@...libre.com,
	nuno.sa@...log.com, andy@...nel.org, arnd@...db.de,
	srini@...nel.org, vkoul@...nel.org, kishon@...nel.org,
	sre@...nel.org, krzysztof.kozlowski@...aro.org,
	linux-arm-msm@...r.kernel.org, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org,
	linux-pm@...r.kernel.org, kernel@...labora.com, wenst@...omium.org,
	casey.connolly@...aro.org,
	Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
	Neil Armstrong <neil.armstrong@...aro.org>
Subject: Re: [PATCH v4 2/7] nvmem: qcom-spmi-sdam: Migrate to
 devm_spmi_subdevice_alloc_and_add()

On Thu, Sep 18, 2025 at 10:00:29PM +0300, Andy Shevchenko wrote:
> I,o.w. I principally disagree on putting MODULE_IMPORT_NS() into the header
> file.

Yes, please never do that, it defeats the purpose of module namespaces
completly.  If you don't want to have module namespaces, don't use them
for your subsytem.  Don't use them and then make them moot by putting
MODULE_IMPORT_NS() in the .h file for the symbols as that's pointless.

thanks,

greg k-h