linux-kernel - Re: [PATCH 4/4] mm: thp: reparent the split queue during memcg offline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202509201556.QAvYX4v3-lkp@intel.com>
Date: Sat, 20 Sep 2025 15:43:18 +0800
From: kernel test robot <lkp@...el.com>
To: Qi Zheng <zhengqi.arch@...edance.com>, hannes@...xchg.org,
	hughd@...gle.com, mhocko@...e.com, roman.gushchin@...ux.dev,
	shakeel.butt@...ux.dev, muchun.song@...ux.dev, david@...hat.com,
	lorenzo.stoakes@...cle.com, ziy@...dia.com,
	baolin.wang@...ux.alibaba.com, Liam.Howlett@...cle.com,
	npache@...hat.com, ryan.roberts@....com, dev.jain@....com,
	baohua@...nel.org, lance.yang@...ux.dev, akpm@...ux-foundation.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, cgroups@...r.kernel.org,
	Qi Zheng <zhengqi.arch@...edance.com>
Subject: Re: [PATCH 4/4] mm: thp: reparent the split queue during memcg
 offline

Hi Qi,

kernel test robot noticed the following build errors:

[auto build test ERROR on next-20250918]
[also build test ERROR on v6.17-rc6]
[cannot apply to akpm-mm/mm-everything rppt-memblock/for-next rppt-memblock/fixes linus/master v6.17-rc6 v6.17-rc5 v6.17-rc4]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Qi-Zheng/mm-thp-replace-folio_memcg-with-folio_memcg_charged/20250919-115219
base:   next-20250918
patch link:    https://lore.kernel.org/r/bbe3bf8bfce081fdf0815481b2a0c83b89b095b8.1758253018.git.zhengqi.arch%40bytedance.com
patch subject: [PATCH 4/4] mm: thp: reparent the split queue during memcg offline
config: x86_64-randconfig-004-20250920 (https://download.01.org/0day-ci/archive/20250920/202509201556.QAvYX4v3-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250920/202509201556.QAvYX4v3-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509201556.QAvYX4v3-lkp@intel.com/

All errors (new ones prefixed by >>):

>> mm/memcontrol.c:3890:2: error: call to undeclared function 'reparent_deferred_split_queue'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    3890 |         reparent_deferred_split_queue(memcg);
         |         ^
   1 error generated.


vim +/reparent_deferred_split_queue +3890 mm/memcontrol.c

  3877	
  3878	static void mem_cgroup_css_offline(struct cgroup_subsys_state *css)
  3879	{
  3880		struct mem_cgroup *memcg = mem_cgroup_from_css(css);
  3881	
  3882		memcg1_css_offline(memcg);
  3883	
  3884		page_counter_set_min(&memcg->memory, 0);
  3885		page_counter_set_low(&memcg->memory, 0);
  3886	
  3887		zswap_memcg_offline_cleanup(memcg);
  3888	
  3889		memcg_offline_kmem(memcg);
> 3890		reparent_deferred_split_queue(memcg);
  3891		reparent_shrinker_deferred(memcg);
  3892		wb_memcg_offline(memcg);
  3893		lru_gen_offline_memcg(memcg);
  3894	
  3895		drain_all_stock(memcg);
  3896	
  3897		mem_cgroup_id_put(memcg);
  3898	}
  3899	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki