linux-kernel - Re: [PATCH v2] tools/nolibc: make time_t robust if __kernel_old_time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b20a1126-9d59-4d8b-a85c-71ec532c2f8f@t-8ch.de>
Date: Sat, 20 Sep 2025 11:07:43 +0200
From: Thomas Weißschuh <linux@...ssschuh.net>
To: Zhouyi Zhou <zhouzhouyi@...il.com>
Cc: w@....eu, rcu@...r.kernel.org, linux-kernel@...r.kernel.org, 
	lance@...osl.org
Subject: Re: [PATCH v2] tools/nolibc: make time_t robust if
 __kernel_old_time_t is missing in host headers

On 2025-09-19 01:46:43+0000, Zhouyi Zhou wrote:
> Commit d5094bcb5bfd ("tools/nolibc: define time_t in terms of
> __kernel_old_time_t") made nolibc use the kernel's time type so that
> `time_t` matches `timespec::tv_sec` on all ABIs (notably x32).
> 
> But since __kernel_old_time_t
> is fairly new, notably from 2020 in commit 94c467ddb273 ("y2038: add
> __kernel_old_timespec and __kernel_old_time_t"), nolibc builds that
> rely on host headers may fail.
> 
> Switch to __kernel_time_t, which is the same as
> __kernel_old_time_t and has existed for longer.    
> 
> Tested in PPC VM of Open Source Lab of Oregon State University
> (./tools/testing/selftests/rcutorture/bin/mkinitrd.sh)
> 
> Fixes: d5094bcb5bfd ("tools/nolibc: define time_t in terms of __kernel_old_time_t")
> Signed-off-by: Zhouyi Zhou <zhouzhouyi@...il.com>                     

Thanks! Although it is fairly late in the developmment cycle I have
applied it to nolibc-next for 6.18.

(...)