| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20250920113912.5c52b1a5@jic23-huawei>
Date: Sat, 20 Sep 2025 11:39:12 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: kernel test robot <lkp@...el.com>
Cc: victor.duicu@...rochip.com, dlechner@...libre.com, nuno.sa@...log.com,
andy@...nel.org, robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
devicetree@...r.kernel.org, marius.cristea@...rochip.com
Subject: Re: [PATCH v5 2/2] iio: temperature: add support for MCP998X
On Fri, 19 Sep 2025 14:27:55 +0800
kernel test robot <lkp@...el.com> wrote:
> Hi,
>
> kernel test robot noticed the following build errors:
>
> [auto build test ERROR on 671b9b6d7f4fe17a174c410397e72253877ca64e]
>
> url: https://github.com/intel-lab-lkp/linux/commits/victor-duicu-microchip-com/dt-bindings-iio-temperature-add-support-for-MCP998X/20250918-192457
> base: 671b9b6d7f4fe17a174c410397e72253877ca64e
> patch link: https://lore.kernel.org/r/20250918111937.5150-3-victor.duicu%40microchip.com
> patch subject: [PATCH v5 2/2] iio: temperature: add support for MCP998X
> config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20250919/202509191423.1OvJW2X1-lkp@intel.com/config)
> compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250919/202509191423.1OvJW2X1-lkp@intel.com/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@...el.com>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202509191423.1OvJW2X1-lkp@intel.com/
>
> All errors (new ones prefixed by >>):
>
> >> drivers/iio/temperature/mcp9982.c:470:3: error: expected expression
> 470 | u8 bulk_read[3];
I guess you may have figured this out by now. It's a scope issue. Needs {}
around these blocks of code.
> | ^
> >> drivers/iio/temperature/mcp9982.c:473:31: error: use of undeclared identifier 'bulk_read'; did you mean 'up_read'?
> 473 | &bulk_read, sizeof(bulk_read));
> | ^~~~~~~~~
> | up_read
> include/linux/rwsem.h:246:13: note: 'up_read' declared here
> 246 | extern void up_read(struct rw_semaphore *sem);
> | ^
> drivers/iio/temperature/mcp9982.c:473:13: error: use of undeclared identifier 'bulk_read'; did you mean 'up_read'?
> 473 | &bulk_read, sizeof(bulk_read));
> | ^~~~~~~~~
> | up_read
> include/linux/rwsem.h:246:13: note: 'up_read' declared here
> 246 | extern void up_read(struct rw_semaphore *sem);
> | ^
> drivers/iio/temperature/mcp9982.c:477:11: error: use of undeclared identifier 'bulk_read'; did you mean 'up_read'?
> 477 | *val = (bulk_read[1] << 8) + (bulk_read[2]);
> | ^~~~~~~~~
> | up_read
> include/linux/rwsem.h:246:13: note: 'up_read' declared here
> 246 | extern void up_read(struct rw_semaphore *sem);
> | ^
> >> drivers/iio/temperature/mcp9982.c:477:11: error: subscript of pointer to function type 'void (struct rw_semaphore *)'
> 477 | *val = (bulk_read[1] << 8) + (bulk_read[2]);
> | ^~~~~~~~~
> drivers/iio/temperature/mcp9982.c:477:33: error: use of undeclared identifier 'bulk_read'; did you mean 'up_read'?
> 477 | *val = (bulk_read[1] << 8) + (bulk_read[2]);
> | ^~~~~~~~~
> | up_read
> include/linux/rwsem.h:246:13: note: 'up_read' declared here
> 246 | extern void up_read(struct rw_semaphore *sem);
> | ^
> drivers/iio/temperature/mcp9982.c:477:33: error: subscript of pointer to function type 'void (struct rw_semaphore *)'
> 477 | *val = (bulk_read[1] << 8) + (bulk_read[2]);
> | ^~~~~~~~~
> drivers/iio/temperature/mcp9982.c:488:3: error: expected expression
> 488 | unsigned long *src;
> | ^
> >> drivers/iio/temperature/mcp9982.c:493:4: error: use of undeclared identifier 'src'
> 493 | *src = tmp_reg;
> | ^
> drivers/iio/temperature/mcp9982.c:494:68: error: use of undeclared identifier 'src'
> 494 | *val = mcp9982_3db_values_map_tbl[priv->sampl_idx][bitmap_weight(src, 2)][0];
> | ^
> drivers/iio/temperature/mcp9982.c:495:69: error: use of undeclared identifier 'src'
> 495 | *val2 = mcp9982_3db_values_map_tbl[priv->sampl_idx][bitmap_weight(src, 2)][1];
> | ^
> 11 errors generated.
>
>
> vim +470 drivers/iio/temperature/mcp9982.c
>
> 426
> 427 static int mcp9982_read_raw(struct iio_dev *indio_dev,
> 428 struct iio_chan_spec const *chan, int *val,
> 429 int *val2, long mask)
> 430 {
> 431 unsigned int tmp_reg, reg_status;
> 432 struct mcp9982_priv *priv = iio_priv(indio_dev);
> 433 int ret;
> 434
> 435 if (test_bit(RUN_STATE, &priv->bit_flags)) {
> 436 /*
> 437 * When working in Run mode, after modifying a parameter (like sampling
> 438 * frequency) we have to wait a delay before reading the new values.
> 439 * We can't determine when the conversion is done based on the BUSY bit.
> 440 */
> 441 if (test_bit(WAIT_BEFORE_READ, &priv->bit_flags)) {
> 442 if (!time_after(jiffies, priv->time_limit))
> 443 mdelay(jiffies_to_msecs(priv->time_limit - jiffies));
> 444 clear_bit(WAIT_BEFORE_READ, &priv->bit_flags);
> 445 }
> 446 } else {
> 447 ret = regmap_write(priv->regmap, MCP9982_ONE_SHOT_ADDR, 1);
> 448 if (ret)
> 449 return ret;
> 450 /*
> 451 * In Standby state after writing in OneShot register wait for
> 452 * the start of conversion and then poll the BUSY bit.
> 453 */
> 454 mdelay(125);
> 455 ret = regmap_read_poll_timeout(priv->regmap, MCP9982_STATUS_ADDR,
> 456 reg_status, !(reg_status & MCP9982_STATUS_BUSY),
> 457 mcp9982_delay_ms[priv->sampl_idx] * USEC_PER_MSEC,
> 458 0);
> 459 if (ret)
> 460 return ret;
> 461 }
> 462 guard(mutex)(&priv->lock);
> 463
> 464 switch (mask) {
> 465 case IIO_CHAN_INFO_RAW:
> 466 /*
> 467 * The Block Read Protocol first returns the number of user readable
> 468 * bytes, held in bulk_read[0], followed by the data.
> 469 */
> > 470 u8 bulk_read[3];
> 471
> 472 ret = regmap_bulk_read(priv->regmap, MCP9982_TEMP_MEM_BLOCK_ADDR(chan->channel),
> > 473 &bulk_read, sizeof(bulk_read));
> 474 if (ret)
> 475 return ret;
> 476
> > 477 *val = (bulk_read[1] << 8) + (bulk_read[2]);
> 478 return IIO_VAL_INT;
> 479 case IIO_CHAN_INFO_SCALE:
> 480 *val = 0;
> 481 *val2 = MCP9982_SCALE;
> 482 return IIO_VAL_INT_PLUS_NANO;
> 483 case IIO_CHAN_INFO_SAMP_FREQ:
> 484 *val = mcp9982_conv_rate[priv->sampl_idx][0];
> 485 *val2 = mcp9982_conv_rate[priv->sampl_idx][1];
> 486 return IIO_VAL_INT_PLUS_MICRO;
> 487 case IIO_CHAN_INFO_LOW_PASS_FILTER_3DB_FREQUENCY:
> 488 unsigned long *src;
> 489
> 490 ret = regmap_read(priv->regmap, MCP9982_RUNNING_AVG_ADDR, &tmp_reg);
> 491 if (ret)
> 492 return ret;
> > 493 *src = tmp_reg;
> 494 *val = mcp9982_3db_values_map_tbl[priv->sampl_idx][bitmap_weight(src, 2)][0];
> 495 *val2 = mcp9982_3db_values_map_tbl[priv->sampl_idx][bitmap_weight(src, 2)][1];
> 496 return IIO_VAL_INT_PLUS_MICRO;
> 497 case IIO_CHAN_INFO_OFFSET:
> 498 *val = MCP9982_OFFSET;
> 499 return IIO_VAL_INT;
> 500 default:
> 501 return -EINVAL;
> 502 }
> 503 }
> 504
>
Powered by blists - more mailing lists