linux-kernel - Re: [PATCH] iio: adc: ad7124: use devm_mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250920120627.307a8bdd@jic23-huawei>
Date: Sat, 20 Sep 2025 12:06:27 +0100
From: Jonathan Cameron <jic23@...nel.org>
To: David Lechner <dlechner@...libre.com>
Cc: Michael Hennerich <Michael.Hennerich@...log.com>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: adc: ad7124: use devm_mutex_init()

On Wed, 17 Sep 2025 10:22:30 -0500
David Lechner <dlechner@...libre.com> wrote:

> Use devm_mutex_init() to initialize the mutex to handle automatically
> freeing in debug builds.
> 
> Signed-off-by: David Lechner <dlechner@...libre.com>
Normally I'd say this isn't worth the churn but fine this time given
all the other patches for this driver.

Applied to iio.git/testing

Jonathan

> ---
>  drivers/iio/adc/ad7124.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c
> index 9ace3e0914f5acab695c0382df758f56f333ae72..9d9250274b9a02e2982e6ceda27009a84413dc2f 100644
> --- a/drivers/iio/adc/ad7124.c
> +++ b/drivers/iio/adc/ad7124.c
> @@ -1482,7 +1482,10 @@ static int ad7124_setup(struct ad7124_state *st)
>  	st->adc_control &= ~AD7124_ADC_CONTROL_MODE;
>  	st->adc_control |= FIELD_PREP(AD7124_ADC_CONTROL_MODE, AD_SD_MODE_IDLE);
>  
> -	mutex_init(&st->cfgs_lock);
> +	ret = devm_mutex_init(dev, &st->cfgs_lock);
> +	if (ret)
> +		return ret;
> +
>  	INIT_KFIFO(st->live_cfgs_fifo);
>  	for (i = 0; i < st->num_channels; i++) {
>  		struct ad7124_channel_config *cfg = &st->channels[i].cfg;
> 
> ---
> base-commit: 561285d048053fec8a3d6d1e3ddc60df11c393a0
> change-id: 20250917-iio-adc-ad7124-use-devm_mutex_init-45a297b1ff8f
> 
> Best regards,