[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20250920-dw9719-v2-0-028cdaa156e5@apitzsch.eu>
Date: Sat, 20 Sep 2025 14:03:39 +0200
From: André Apitzsch via B4 Relay <devnull+git.apitzsch.eu@...nel.org>
To: Mauro Carvalho Chehab <mchehab@...nel.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
Sakari Ailus <sakari.ailus@...ux.intel.com>,
Daniel Scally <djrscally@...il.com>
Cc: ~postmarketos/upstreaming@...ts.sr.ht, phone-devel@...r.kernel.org,
linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
Val Packett <val@...kett.cool>,
André Apitzsch <git@...tzsch.eu>
Subject: [PATCH v2 0/8] media: i2c: dw9719: add DT compatible and DW9718S
support
The DW9718S voice coil motor is found on various smartphones like
motorola-nora that are currently being worked on in the postmarketOS
community. Since the way it operates is very similar to DW9719, this
patch series adds support for it to the existing dw9719 driver. Because
that driver did not yet support DT, we also add DT bindings and the
dongwoon,dw9719 ofw compatible. With DW9718S, the driver was
tested fully, including runtime PM.
This is a follow-up of [1] and [2].
Changes compared to previous submission:
* Deprecate dongwoon,vcm-freq in favor of dongwoon,vcm-prescale
* Instead of per-device config struct use model ID to handle cases
[1] https://lore.kernel.org/linux-media/20250210082035.8670-1-val@packett.cool/
[2] https://lore.kernel.org/linux-media/20250209-dw9761dts-v3-0-14d3f00f0585@apitzsch.eu/
Signed-off-by: André Apitzsch <git@...tzsch.eu>
---
Changes in v2:
- Add patch (3) which removes i2c device table
- Restructure patches because of that
- keep patches 1 and 2
- add patch 3
- patch 6 becomes patch 4
- patch 3 becomes patch 5
- patch 4 becomes patch 6
- patch 5 becomes patch 7
- patch 7 becomes patch 8
- Patch 1 (bindings)
- Remove unneeded 'minimum: 0'
- Remove if/then that handles 'default' to reduce complexity
- Add myself as maintainer
- Patch 5
- Fix void-pointer-to-enum-cast warning
- Patch 7
- Drop pm_runtime_mark_last_busy(); it is already called by
pm_runtime_put_autosuspend()
- Patch 8
- Remove extra parentheses
- Print error if writing to power register fails
- Add reason for doubled waiting time during power up to comment
- Pass NULL instead of unused 'ret' to cci_write()
- Link to v1: https://lore.kernel.org/r/20250817-dw9719-v1-0-426f46c69a5a@apitzsch.eu
---
André Apitzsch (3):
dt-bindings: media: i2c: Add DW9718S, DW9719 and DW9761 VCM
media: i2c: dw9719: Deprecate dongwoon,vcm-freq
media: i2c: dw9719: Remove unused i2c device id table
Val Packett (5):
media: i2c: dw9719: Add an of_match_table
media: i2c: dw9719: Add driver_data matching
media: i2c: dw9719: Add DW9718S support
media: i2c: dw9719: Update PM last busy time upon close
media: i2c: dw9719: Fix power on/off sequence
.../bindings/media/i2c/dongwoon,dw9719.yaml | 88 +++++++++++++++++
drivers/media/i2c/dw9719.c | 110 +++++++++++++++++----
2 files changed, 178 insertions(+), 20 deletions(-)
---
base-commit: 846bd2225ec3cfa8be046655e02b9457ed41973e
change-id: 20250709-dw9719-8a8822efc1b1
Best regards,
--
André Apitzsch <git@...tzsch.eu>
Powered by blists - more mailing lists