| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202509210053.BtsqeDKp-lkp@intel.com>
Date: Sat, 20 Sep 2025 23:04:51 +0800
From: kernel test robot <lkp@...el.com>
To: Viken Dadhaniya <viken.dadhaniya@....qualcomm.com>, mkl@...gutronix.de,
mani@...nel.org, thomas.kopp@...rochip.com,
mailhol.vincent@...adoo.fr, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, linus.walleij@...aro.org, brgl@...ev.pl,
linux-can@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, mukesh.savaliya@....qualcomm.com,
anup.kulkarni@....qualcomm.com,
Gregor Herburger <gregor.herburger@...tq-group.com>,
Viken Dadhaniya <viken.dadhaniya@....qualcomm.com>
Subject: Re: [PATCH v4 4/6] can: mcp251xfd: only configure PIN1 when rx_int
is set
Hi Viken,
kernel test robot noticed the following build warnings:
[auto build test WARNING on mkl-can-next/testing]
[also build test WARNING on linus/master v6.17-rc6 next-20250919]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Viken-Dadhaniya/can-mcp251xfd-move-chip-sleep-mode-into-runtime-pm/20250918-145404
base: https://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git testing
patch link: https://lore.kernel.org/r/20250918064903.241372-5-viken.dadhaniya%40oss.qualcomm.com
patch subject: [PATCH v4 4/6] can: mcp251xfd: only configure PIN1 when rx_int is set
config: x86_64-randconfig-123-20250920 (https://download.01.org/0day-ci/archive/20250921/202509210053.BtsqeDKp-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250921/202509210053.BtsqeDKp-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509210053.BtsqeDKp-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c:49:19: sparse: sparse: cast to restricted __be16
>> drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c:71:21: sparse: sparse: incorrect type in assignment (different base types) @@ expected unsigned short [assigned] [usertype] reg @@ got restricted __be16 [usertype] @@
drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c:71:21: sparse: expected unsigned short [assigned] [usertype] reg
drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c:71:21: sparse: got restricted __be16 [usertype]
vim +49 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c
875347fe575636 drivers/net/can/spi/mcp25xxfd/mcp25xxfd-regmap.c Marc Kleine-Budde 2020-09-18 41
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 42 static int
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 43 mcp251xfd_regmap_nocrc_gather_write(void *context,
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 44 const void *reg_p, size_t reg_len,
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 45 const void *val, size_t val_len)
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 46 {
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 47 const u16 byte_exclude = MCP251XFD_REG_IOCON +
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 48 mcp251xfd_first_byte_set(MCP251XFD_REG_IOCON_GPIO_MASK);
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 @49 u16 reg = be16_to_cpu(*(u16 *)reg_p) & MCP251XFD_SPI_ADDRESS_MASK;
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 50 int ret;
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 51
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 52 /* Never write to bits 16..23 of IOCON register to avoid clearing of LAT0/LAT1
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 53 *
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 54 * According to MCP2518FD Errata DS80000789E 5 writing IOCON register using one
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 55 * SPI write command clears LAT0/LAT1.
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 56 *
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 57 * Errata Fix/Work Around suggests to write registers with single byte
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 58 * write instructions. However, it seems that the byte at 0xe06(IOCON[23:16])
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 59 * is for read-only access and writing to it causes the clearing of LAT0/LAT1.
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 60 */
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 61 if (reg <= byte_exclude && reg + val_len > byte_exclude) {
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 62 size_t len = byte_exclude - reg;
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 63
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 64 /* Write up to 0xe05 */
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 65 ret = _mcp251xfd_regmap_nocrc_gather_write(context, reg_p, reg_len, val, len);
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 66 if (ret)
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 67 return ret;
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 68
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 69 /* Write from 0xe07 on */
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 70 reg += len + 1;
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 @71 reg = cpu_to_be16(MCP251XFD_SPI_INSTRUCTION_WRITE | reg);
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 72 return _mcp251xfd_regmap_nocrc_gather_write(context, ®, reg_len,
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 73 val + len + 1,
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 74 val_len - len - 1);
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 75 }
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 76
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 77 return _mcp251xfd_regmap_nocrc_gather_write(context, reg_p, reg_len,
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 78 val, val_len);
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 79 }
182c647943b5c0 drivers/net/can/spi/mcp251xfd/mcp251xfd-regmap.c Gregor Herburger 2025-09-18 80
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists