| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <qdfm5e2uaqplzu3y4gajjhhe6khruxyelwuqn425jvcfrrxlb2@bqrkmzofte4r>
Date: Sat, 20 Sep 2025 18:46:49 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Eric Gonçalves <ghatto404@...il.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] arm64: dts: qcom: r0q: add touchscreen support
On Sat, Sep 20, 2025 at 01:46:34AM +0000, Eric Gonçalves wrote:
> Enable the ST-Microelectronics FTS2BA61Y touchscreen. This patch
> depends on "Input: add support for the STM FTS2BA61Y touchscreen".
>
> The device has an issue where SPI 8 (the bus which the touchscreen is
> connected to) is not working properly right now, so
> spi-gpio is used instead.
>
> Signed-off-by: Eric Gonçalves <ghatto404@...il.com>
> ---
> .../boot/dts/qcom/sm8450-samsung-r0q.dts | 167 ++++++++++++++++++
> 1 file changed, 167 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts b/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
> index 70e953824996..7bf56564dfc6 100644
> --- a/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
> @@ -55,6 +55,45 @@ splash-region@...00000 {
> };
> };
>
Please add a comment that you have to use spi-gpio and ideally a brief
description of the issue.
With that fixed:
> + spi_gpio: spi-gpio@0 {
> + compatible = "spi-gpio";
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&spi_clk_tsp_active &spi_mosi_tsp_active &spi_miso_tsp_active>;
> + pinctrl-1 = <&spi_clk_tsp_sleep &spi_mosi_tsp_sleep &spi_miso_tsp_sleep>;
> +
> + status = "okay";
status isn't necessary for new devices. It's a default value.
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + sck-gpios = <&tlmm 30 GPIO_ACTIVE_HIGH>;
> + mosi-gpios = <&tlmm 29 GPIO_ACTIVE_HIGH>;
> + miso-gpios = <&tlmm 28 GPIO_ACTIVE_HIGH>;
> + cs-gpios = <&tlmm 31 GPIO_ACTIVE_LOW>;
> +
> + num-chipselects = <1>;
> +
> + spi-max-frequency = <5000000>;
> +
> + touchscreen@0 {
> + compatible = "st,fts2ba61y";
> + reg = <0>;
> + spi-max-frequency = <5000000>;
> +
> + vdd-supply = <&vreg_l8c_1p8>;
> + avdd-supply = <&vreg_l11c_3p0>;
> +
> + interrupt-parent = <&tlmm>;
> + interrupts = <46 IRQ_TYPE_LEVEL_LOW>;
> +
> + pinctrl-names = "default", "sleep";
> + pinctrl-0 = <&tsp_int_active>;
> + pinctrl-1 = <&tsp_int_sleep>;
> +
> + status = "okay";
> + };
> + };
> +
> vph_pwr: regulator-vph-pwr {
> compatible = "regulator-fixed";
> regulator-name = "vph_pwr";
> @@ -132,6 +171,18 @@ vreg_l1c_1p8: ldo1 {
> regulator-max-microvolt = <1800000>;
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> };
> +
> + vreg_l8c_1p8: ldo8 {
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> + };
> +
> + vreg_l11c_3p0: ldo11 {
> + regulator-min-microvolt = <3000000>;
> + regulator-max-microvolt = <3000000>;
> + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> + };
> };
> };
>
> @@ -156,6 +207,122 @@ &pon_resin {
>
> &tlmm {
> gpio-reserved-ranges = <36 4>; /* SPI (Unused) */
> +
> + spi_clk_tsp_active: spi_clk_tsp_active {
> + mux {
> + pins = "gpio30";
> + function = "gpio";
> + };
> + config {
> + pins = "gpio30";
> + drive-strength = <6>;
> + bias-disable;
> + };
> + };
> +
> + spi_clk_tsp_sleep: spi_clk_tsp_sleep {
> + mux {
> + pins = "gpio30";
> + function = "gpio";
> + };
> + config {
> + pins = "gpio30";
> + drive-strength = <6>;
> + input-enable;
> + bias-pull-down;
> + };
> + };
> +
> + spi_cs_tsp_active: spi_cs_tsp_active {
> + mux {
> + pins = "gpio31";
> + function = "gpio";
> + };
> + config {
> + pins = "gpio31";
> + drive-strength = <6>;
> + bias-disable;
> + };
> + };
> +
> + spi_cs_tsp_sleep: spi_cs_tsp_sleep {
> + mux {
> + pins = "gpio31";
> + function = "gpio";
> + };
> + config {
> + pins = "gpio31";
> + drive-strength = <6>;
> + input-enable;
> + bias-pull-down;
> + };
> + };
> +
> + spi_miso_tsp_active: spi_miso_tsp_active {
> + mux {
> + pins = "gpio28";
> + function = "gpio";
> + };
> + config {
> + pins = "gpio28";
> + drive-strength = <6>;
> + bias-disable;
> + };
> + };
> +
> + spi_miso_tsp_sleep: spi_miso_tsp_sleep {
> + mux {
> + pins = "gpio28";
> + function = "gpio";
> + };
> + config {
> + pins = "gpio28";
> + drive-strength = <6>;
> + input-enable;
> + bias-pull-down;
> + };
> + };
> +
> + spi_mosi_tsp_active: spi_mosi_tsp_active {
> + mux {
> + pins = "gpio29";
> + function = "gpio";
> + };
> + config {
> + pins = "gpio29";
> + drive-strength = <6>;
> + bias-disable;
> + };
> + };
> +
> + spi_mosi_tsp_sleep: spi_mosi_tsp_sleep {
> + mux {
> + pins = "gpio29";
> + function = "gpio";
> + };
> + config {
> + pins = "gpio29";
> + drive-strength = <6>;
> + input-enable;
> + bias-pull-down;
> + };
> + };
> +
> + tsp_int_active: tsp_int_active {
> + pins = "gpio46";
> + function = "gpio";
> + drive-strength = <2>;
> + input-enable;
> + bias-disable;
> + };
> +
> + tsp_int_sleep: tsp_int_sleep_state {
> + pins = "gpio46";
> + function = "gpio";
> + drive-strength = <2>;
> + input-enable;
> + bias-disable;
> + };
> };
>
> &usb_1 {
> --
> 2.51.0
>
--
With best wishes
Dmitry
Powered by blists - more mailing lists