linux-kernel - Re: [PATCH] misc: cb710: Replace deprecated PCI functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aM7Vab4TWill5vev@qmqm.qmqm.pl>
Date: Sat, 20 Sep 2025 18:25:13 +0200
From: Michał Mirosław <mirq-linux@...e.qmqm.pl>
To: Madhur Kumar <madhurkumar004@...il.com>
Cc: arnd@...db.de, gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] misc: cb710: Replace deprecated PCI functions

On Fri, Sep 19, 2025 at 02:02:14PM +0530, Madhur Kumar wrote:
> pcim_iomap_table() and pcim_iomap_regions() have been deprecated.
> Replace them with pcim_iomap_region().
> 
> Signed-off-by: Madhur Kumar <madhurkumar004@...il.com>

Acked-by: Michał Mirosław <mirq-linux@...e.qmqm.pl>

> ---
>  drivers/misc/cb710/core.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/misc/cb710/core.c b/drivers/misc/cb710/core.c
> index 55b7ee0e8f93..033e9e6d37db 100644
> --- a/drivers/misc/cb710/core.c
> +++ b/drivers/misc/cb710/core.c
> @@ -223,13 +223,12 @@ static int cb710_probe(struct pci_dev *pdev,
>  	if (err)
>  		return err;
>  
> -	err = pcim_iomap_regions(pdev, 0x0001, KBUILD_MODNAME);
> -	if (err)
> -		return err;
>  
>  	spin_lock_init(&chip->irq_lock);
>  	chip->pdev = pdev;
> -	chip->iobase = pcim_iomap_table(pdev)[0];
> +	chip->iobase = pcim_iomap_region(pdev, 0, KBUILD_MODNAME);
> +	if(!chip->iobase)
> +		return -ENOMEM;
>  
>  	pci_set_drvdata(pdev, chip);
>  
> -- 
> 2.51.0
> 

-- 
Michał Mirosław