| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202509210003.8eaSRC0k-lkp@intel.com>
Date: Sun, 21 Sep 2025 01:12:24 +0800
From: kernel test robot <lkp@...el.com>
To: Joshua Hahn <joshua.hahnjy@...il.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Johannes Weiner <hannes@...xchg.org>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
Linux Memory Management List <linux-mm@...ck.org>,
Chris Mason <chris.mason@...ionio.com>,
Kiryl Shutsemau <kirill@...temov.name>,
Brendan Jackman <jackmanb@...gle.com>,
Michal Hocko <mhocko@...e.com>,
Suren Baghdasaryan <surenb@...gle.com>,
Vlastimil Babka <vbabka@...e.cz>, Zi Yan <ziy@...dia.com>,
linux-kernel@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH 4/4] mm/page_alloc: Batch page freeing in
free_frozen_page_commit
Hi Joshua,
kernel test robot noticed the following build warnings:
[auto build test WARNING on 097a6c336d0080725c626fda118ecfec448acd0f]
url: https://github.com/intel-lab-lkp/linux/commits/Joshua-Hahn/mm-page_alloc-vmstat-Simplify-refresh_cpu_vm_stats-change-detection/20250920-035357
base: 097a6c336d0080725c626fda118ecfec448acd0f
patch link: https://lore.kernel.org/r/20250919195223.1560636-5-joshua.hahnjy%40gmail.com
patch subject: [PATCH 4/4] mm/page_alloc: Batch page freeing in free_frozen_page_commit
config: powerpc-taishan_defconfig (https://download.01.org/0day-ci/archive/20250921/202509210003.8eaSRC0k-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250921/202509210003.8eaSRC0k-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509210003.8eaSRC0k-lkp@intel.com/
All warnings (new ones prefixed by >>):
mm/page_alloc.c:2891:23: error: use of undeclared identifier 'UP_flags'; did you mean 'fpi_flags'?
2891 | pcp_trylock_finish(UP_flags);
| ^~~~~~~~
| fpi_flags
mm/page_alloc.c:109:53: note: expanded from macro 'pcp_trylock_finish'
109 | #define pcp_trylock_finish(flags) local_irq_restore(flags)
| ^
include/linux/irqflags.h:240:61: note: expanded from macro 'local_irq_restore'
240 | #define local_irq_restore(flags) do { raw_local_irq_restore(flags); } while (0)
| ^
include/linux/irqflags.h:177:28: note: expanded from macro 'raw_local_irq_restore'
177 | typecheck(unsigned long, flags); \
| ^
include/linux/typecheck.h:11:9: note: expanded from macro 'typecheck'
11 | typeof(x) __dummy2; \
| ^
mm/page_alloc.c:2833:29: note: 'fpi_flags' declared here
2833 | unsigned int order, fpi_t fpi_flags)
| ^
>> mm/page_alloc.c:2891:4: warning: comparison of distinct pointer types ('unsigned long *' and 'typeof (fpi_flags) *' (aka 'int *')) [-Wcompare-distinct-pointer-types]
2891 | pcp_trylock_finish(UP_flags);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
mm/page_alloc.c:109:35: note: expanded from macro 'pcp_trylock_finish'
109 | #define pcp_trylock_finish(flags) local_irq_restore(flags)
| ^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/irqflags.h:240:39: note: expanded from macro 'local_irq_restore'
240 | #define local_irq_restore(flags) do { raw_local_irq_restore(flags); } while (0)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/irqflags.h:177:3: note: expanded from macro 'raw_local_irq_restore'
177 | typecheck(unsigned long, flags); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/typecheck.h:12:18: note: expanded from macro 'typecheck'
12 | (void)(&__dummy == &__dummy2); \
| ~~~~~~~~ ^ ~~~~~~~~~
mm/page_alloc.c:2891:23: error: use of undeclared identifier 'UP_flags'; did you mean 'fpi_flags'?
2891 | pcp_trylock_finish(UP_flags);
| ^~~~~~~~
| fpi_flags
mm/page_alloc.c:109:53: note: expanded from macro 'pcp_trylock_finish'
109 | #define pcp_trylock_finish(flags) local_irq_restore(flags)
| ^
include/linux/irqflags.h:240:61: note: expanded from macro 'local_irq_restore'
240 | #define local_irq_restore(flags) do { raw_local_irq_restore(flags); } while (0)
| ^
include/linux/irqflags.h:179:26: note: expanded from macro 'raw_local_irq_restore'
179 | arch_local_irq_restore(flags); \
| ^
mm/page_alloc.c:2833:29: note: 'fpi_flags' declared here
2833 | unsigned int order, fpi_t fpi_flags)
| ^
mm/page_alloc.c:2893:24: error: use of undeclared identifier 'UP_flags'; did you mean 'fpi_flags'?
2893 | pcp_trylock_prepare(UP_flags);
| ^~~~~~~~
| fpi_flags
mm/page_alloc.c:108:51: note: expanded from macro 'pcp_trylock_prepare'
108 | #define pcp_trylock_prepare(flags) local_irq_save(flags)
| ^
include/linux/irqflags.h:239:55: note: expanded from macro 'local_irq_save'
239 | #define local_irq_save(flags) do { raw_local_irq_save(flags); } while (0)
| ^
include/linux/irqflags.h:172:28: note: expanded from macro 'raw_local_irq_save'
172 | typecheck(unsigned long, flags); \
| ^
include/linux/typecheck.h:11:9: note: expanded from macro 'typecheck'
11 | typeof(x) __dummy2; \
| ^
mm/page_alloc.c:2833:29: note: 'fpi_flags' declared here
2833 | unsigned int order, fpi_t fpi_flags)
| ^
mm/page_alloc.c:2893:4: warning: comparison of distinct pointer types ('unsigned long *' and 'typeof (fpi_flags) *' (aka 'int *')) [-Wcompare-distinct-pointer-types]
2893 | pcp_trylock_prepare(UP_flags);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
mm/page_alloc.c:108:36: note: expanded from macro 'pcp_trylock_prepare'
108 | #define pcp_trylock_prepare(flags) local_irq_save(flags)
| ^~~~~~~~~~~~~~~~~~~~~
include/linux/irqflags.h:239:36: note: expanded from macro 'local_irq_save'
239 | #define local_irq_save(flags) do { raw_local_irq_save(flags); } while (0)
| ^~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/irqflags.h:172:3: note: expanded from macro 'raw_local_irq_save'
172 | typecheck(unsigned long, flags); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/typecheck.h:12:18: note: expanded from macro 'typecheck'
12 | (void)(&__dummy == &__dummy2); \
| ~~~~~~~~ ^ ~~~~~~~~~
mm/page_alloc.c:2893:24: error: use of undeclared identifier 'UP_flags'
2893 | pcp_trylock_prepare(UP_flags);
| ^
mm/page_alloc.c:2896:24: error: use of undeclared identifier 'UP_flags'; did you mean 'fpi_flags'?
2896 | pcp_trylock_finish(UP_flags);
| ^~~~~~~~
| fpi_flags
mm/page_alloc.c:109:53: note: expanded from macro 'pcp_trylock_finish'
109 | #define pcp_trylock_finish(flags) local_irq_restore(flags)
| ^
include/linux/irqflags.h:240:61: note: expanded from macro 'local_irq_restore'
240 | #define local_irq_restore(flags) do { raw_local_irq_restore(flags); } while (0)
| ^
include/linux/irqflags.h:177:28: note: expanded from macro 'raw_local_irq_restore'
177 | typecheck(unsigned long, flags); \
| ^
include/linux/typecheck.h:11:9: note: expanded from macro 'typecheck'
11 | typeof(x) __dummy2; \
| ^
mm/page_alloc.c:2833:29: note: 'fpi_flags' declared here
2833 | unsigned int order, fpi_t fpi_flags)
| ^
mm/page_alloc.c:2896:5: warning: comparison of distinct pointer types ('unsigned long *' and 'typeof (fpi_flags) *' (aka 'int *')) [-Wcompare-distinct-pointer-types]
2896 | pcp_trylock_finish(UP_flags);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
mm/page_alloc.c:109:35: note: expanded from macro 'pcp_trylock_finish'
109 | #define pcp_trylock_finish(flags) local_irq_restore(flags)
| ^~~~~~~~~~~~~~~~~~~~~~~~
include/linux/irqflags.h:240:39: note: expanded from macro 'local_irq_restore'
240 | #define local_irq_restore(flags) do { raw_local_irq_restore(flags); } while (0)
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/irqflags.h:177:3: note: expanded from macro 'raw_local_irq_restore'
177 | typecheck(unsigned long, flags); \
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
include/linux/typecheck.h:12:18: note: expanded from macro 'typecheck'
12 | (void)(&__dummy == &__dummy2); \
vim +2891 mm/page_alloc.c
2823
2824 /*
2825 * Tune pcp alloc factor and adjust count & free_count. Free pages to bring the
2826 * pcp's watermarks below high.
2827 *
2828 * May return a freed pcp, if during page freeing the pcp spinlock cannot be
2829 * reacquired. Return true if pcp is locked, false otherwise.
2830 */
2831 static bool free_frozen_page_commit(struct zone *zone,
2832 struct per_cpu_pages *pcp, struct page *page, int migratetype,
2833 unsigned int order, fpi_t fpi_flags)
2834 {
2835 int high, batch;
2836 int to_free, to_free_batched;
2837 int pindex;
2838 bool free_high = false;
2839
2840 /*
2841 * On freeing, reduce the number of pages that are batch allocated.
2842 * See nr_pcp_alloc() where alloc_factor is increased for subsequent
2843 * allocations.
2844 */
2845 pcp->alloc_factor >>= 1;
2846 __count_vm_events(PGFREE, 1 << order);
2847 pindex = order_to_pindex(migratetype, order);
2848 list_add(&page->pcp_list, &pcp->lists[pindex]);
2849 pcp->count += 1 << order;
2850
2851 batch = READ_ONCE(pcp->batch);
2852 /*
2853 * As high-order pages other than THP's stored on PCP can contribute
2854 * to fragmentation, limit the number stored when PCP is heavily
2855 * freeing without allocation. The remainder after bulk freeing
2856 * stops will be drained from vmstat refresh context.
2857 */
2858 if (order && order <= PAGE_ALLOC_COSTLY_ORDER) {
2859 free_high = (pcp->free_count >= (batch + pcp->high_min / 2) &&
2860 (pcp->flags & PCPF_PREV_FREE_HIGH_ORDER) &&
2861 (!(pcp->flags & PCPF_FREE_HIGH_BATCH) ||
2862 pcp->count >= batch));
2863 pcp->flags |= PCPF_PREV_FREE_HIGH_ORDER;
2864 } else if (pcp->flags & PCPF_PREV_FREE_HIGH_ORDER) {
2865 pcp->flags &= ~PCPF_PREV_FREE_HIGH_ORDER;
2866 }
2867 if (pcp->free_count < (batch << CONFIG_PCP_BATCH_SCALE_MAX))
2868 pcp->free_count += (1 << order);
2869
2870 if (unlikely(fpi_flags & FPI_TRYLOCK)) {
2871 /*
2872 * Do not attempt to take a zone lock. Let pcp->count get
2873 * over high mark temporarily.
2874 */
2875 return true;
2876 }
2877 high = nr_pcp_high(pcp, zone, batch, free_high);
2878 to_free = nr_pcp_free(pcp, batch, high, free_high);
2879 while (to_free > 0 && pcp->count >= high) {
2880 to_free_batched = min(to_free, batch);
2881 free_pcppages_bulk(zone, to_free_batched, pcp, pindex);
2882 if (test_bit(ZONE_BELOW_HIGH, &zone->flags) &&
2883 zone_watermark_ok(zone, 0, high_wmark_pages(zone),
2884 ZONE_MOVABLE, 0))
2885 clear_bit(ZONE_BELOW_HIGH, &zone->flags);
2886
2887 high = nr_pcp_high(pcp, zone, batch, free_high);
2888 to_free -= to_free_batched;
2889 if (pcp->count >= high) {
2890 pcp_spin_unlock(pcp);
> 2891 pcp_trylock_finish(UP_flags);
2892
2893 pcp_trylock_prepare(UP_flags);
2894 pcp = pcp_spin_trylock(zone->per_cpu_pageset);
2895 if (!pcp) {
2896 pcp_trylock_finish(UP_flags);
2897 return false;
2898 }
2899 }
2900 }
2901
2902 return true;
2903 }
2904
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists