linux-kernel - Re: [PATCH 28/35] cifs: Fix smb2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAH2r5msw5+TxRRO7Ap9eaQX2W4AbZ4bqRHs=0Kv9O1mjV6TvBw@mail.gmail.com>
Date: Sat, 20 Sep 2025 12:37:23 -0500
From: Steve French <smfrench@...il.com>
To: Pali Rohár <pali@...nel.org>
Cc: Steve French <sfrench@...ba.org>, Paulo Alcantara <pc@...guebit.com>, 
	ronnie sahlberg <ronniesahlberg@...il.com>, linux-cifs@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 28/35] cifs: Fix smb2_unlink() to fail on directory

And of the remaining patches only 2 apply (patch 33 and patch 35) on
current mainline

On Sat, Sep 20, 2025 at 12:34 PM Steve French <smfrench@...il.com> wrote:
>
> This did not merge to current mainline
>
> On Sun, Aug 31, 2025 at 7:37 AM Pali Rohár <pali@...nel.org> wrote:
> >
> > unlink() should fail on the directory with ENOTDIR error code.
> > Flag CREATE_NOT_DIR handles that.
> >
> > Signed-off-by: Pali Rohár <pali@...nel.org>
> > ---
> >  fs/smb/client/smb2inode.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/fs/smb/client/smb2inode.c b/fs/smb/client/smb2inode.c
> > index c8b0e9b2438f..c69293fcf26c 100644
> > --- a/fs/smb/client/smb2inode.c
> > +++ b/fs/smb/client/smb2inode.c
> > @@ -1348,7 +1348,7 @@ smb2_unlink(const unsigned int xid, struct cifs_tcon *tcon, const char *name,
> >
> >         oparms = CIFS_OPARMS(cifs_sb, tcon, name,
> >                              DELETE, FILE_OPEN,
> > -                            CREATE_DELETE_ON_CLOSE | OPEN_REPARSE_POINT,
> > +                            CREATE_DELETE_ON_CLOSE | CREATE_NOT_DIR | OPEN_REPARSE_POINT,
> >                              ACL_NO_MODE);
> >         int rc = smb2_compound_op(xid, tcon, cifs_sb, name, &oparms,
> >                                   NULL, &(int){SMB2_OP_DELETE}, 1,
> > --
> > 2.20.1
> >
> >
>
>
> --
> Thanks,
>
> Steve



-- 
Thanks,

Steve