linux-kernel - Re: [PATCH 3/5] arm64: dts: qcom: r0q: enable max77705 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7A9A8218-EE98-4548-A9F6-14DD278D47CD@gmail.com>
Date: Sat, 20 Sep 2025 15:04:24 -0300
From: Eric Gonçalves <ghatto404@...il.com>
To: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
CC: Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
 devicetree@...r.kernel.org, linux-arm-msm@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] arm64: dts: qcom: r0q: enable max77705 PMIC



On September 20, 2025 12:48:55 PM GMT-03:00, Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com> wrote:
>On Sat, Sep 20, 2025 at 01:46:35AM +0000, Eric Gonçalves wrote:
>> The Samsung Galaxy S22 uses max77705 as its charger, fuelgauge and haptic
>> PMIC, enable the fuelgauge and charger for now.
>> 
>> Signed-off-by: Eric Gonçalves <ghatto404@...il.com>
>> ---
>>  .../boot/dts/qcom/sm8450-samsung-r0q.dts      | 34 +++++++++++++++++++
>>  1 file changed, 34 insertions(+)
>> 
>> diff --git a/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts b/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
>> index 7bf56564dfc6..c1b0b21c0ec5 100644
>> --- a/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
>> +++ b/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
>> @@ -14,6 +14,16 @@ / {
>>  	compatible = "samsung,r0q", "qcom,sm8450";
>>  	chassis-type = "handset";
>>  
>> +	battery: battery {
>> +		compatible = "simple-battery";
>> +
>> +		constant-charge-current-max-microamp = <2150000>;
>> +		charge-full-design-microamp-hours = <3700000>;
>> +		over-voltage-threshold-microvolt = <4500000>;
>> +		voltage-min-design-microvolt = <3400000>;
>> +		voltage-max-design-microvolt = <4350000>;
>> +	};
>> +
>>  	chosen {
>>  		#address-cells = <2>;
>>  		#size-cells = <2>;
>> @@ -186,6 +196,26 @@ vreg_l11c_3p0: ldo11 {
>>  	};
>>  };
>>  
>> +&i2c5 {
>> +	status = "okay";
>
>Could you please also add 'clock-frequency' for this bus?
Will do, thanks
>
>LGTM otherwise.
>
>> +
>> +	max77705_charger: charger@69 {
>> +	    compatible = "maxim,max77705-charger";
>> +	    reg = <0x69>;
>> +	    monitored-battery = <&battery>;
>> +	    interrupt-parent = <&tlmm>;
>> +	    interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
>> +	};
>> +
>> +	fuel-gauge@36 {
>> +		reg = <0x36>;
>> +		compatible = "maxim,max77705-battery";
>> +		power-supplies = <&max77705_charger>;
>> +		interrupt-parent = <&tlmm>;
>> +		interrupts = <5 IRQ_TYPE_LEVEL_LOW>;
>> +	};
>> +};
>> +
>>  &pm8350_gpios {
>>  	vol_up_n: vol-up-n-state {
>>  		pins = "gpio6";
>> @@ -345,3 +375,7 @@ &usb_1_hsphy {
>>  
>>  	status = "okay";
>>  };
>> +
>> +&qupv3_id_0 {
>> +	status = "okay";
>> +};
>> -- 
>> 2.51.0
>> 
>