linux-kernel - Re: [PATCH v2 1/2] rust: clk: implement Send and Sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <0EAFA337-2E62-489E-9C22-61A6E1813C8A@collabora.com>
Date: Sat, 20 Sep 2025 20:43:05 +0200
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: Stephen Boyd <sboyd@...nel.org>,
 Boqun Feng <boqun.feng@...il.com>,
 Michael Turquette <mturquette@...libre.com>,
 Miguel Ojeda <ojeda@...nel.org>,
 Alex Gaynor <alex.gaynor@...il.com>,
 Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <lossin@...nel.org>,
 Andreas Hindborg <a.hindborg@...nel.org>,
 Trevor Gross <tmgross@...ch.edu>,
 Danilo Krummrich <dakr@...nel.org>,
 "Rafael J. Wysocki" <rafael@...nel.org>,
 Viresh Kumar <viresh.kumar@...aro.org>,
 linux-clk@...r.kernel.org,
 rust-for-linux@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 linux-pm@...r.kernel.org
Subject: Re: [PATCH v2 1/2] rust: clk: implement Send and Sync



> On 20 Sep 2025, at 19:12, Alice Ryhl <aliceryhl@...gle.com> wrote:
> 
> On Sat, Sep 20, 2025 at 7:06 AM Stephen Boyd <sboyd@...nel.org> wrote:
>> 
>> Quoting Daniel Almeida (2025-09-10 11:47:30)
>>> Hi Boqun,
>>> 
>>>> On 10 Sep 2025, at 14:49, Boqun Feng <boqun.feng@...il.com> wrote:
>>>> 
>>>> On Wed, Sep 10, 2025 at 02:28:27PM -0300, Daniel Almeida wrote:
>>>>> From: Alice Ryhl <aliceryhl@...gle.com>
>>>>> 
>>>>> These traits are required for drivers to embed the Clk type in their own
>>>>> data structures because driver data structures are usually required to
>>>>> be Send. See e.g. [1] for the kind of workaround that drivers currently
>>>>> need due to lacking this annotation.
>>>>> 
>>>>> Link: https://lore.kernel.org/rust-for-linux/20250812-tyr-v2-1-9e0f3dc9da95@collabora.com/ [1]
>>>>> Signed-off-by: Daniel Almeida <daniel.almeida@...labora.com>
>>>>> Signed-off-by: Alice Ryhl <aliceryhl@...gle.com>
>>>>> Reviewed-by: Danilo Krummrich <dakr@...nel.org>
>>>>> Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
>>>>> Reviewed-by: Daniel Almeida <daniel.almeida@...labora.com>
>>>> 
>>>> This tag list looks a bit weird to me. Why is there a SoB from you
>>>> before Alice's SoB? At least for the usage I'm familiar with, outside
>>>> the case of Co-developed-bys, multiple SoBs is used for recording how
>>>> the patches are routed. For example, if I have a patch that has my SoB
>>>> and I send it to you, you queue in your tree and then send out to other
>>>> maintainers for merging, in general you would put your SoB after mine in
>>>> that case. But I don't think that's case here? Alice's patch has only
>>>> her SoB:
>>>> 
>>>> https://lore.kernel.org/rust-for-linux/20250904-clk-send-sync-v1-1-48d023320eb8@google.com/
>>>> 
>>>> What's the intention of the SoB tag here?
>>>> 
>>>> Otherwise the patch looks good to me. If we get the tag list resolved,
>>>> feel free to add:
>>>> 
>>>> Reviewed-by: Boqun Feng <boqun.feng@...il.com>
>>>> 
>>>> Regards,
>>>> Boqun
>>>> 
>>> 
>>> You have to include your SOB when submitting patches from others.
>>> 
>>> This is something I tend to forget often, so I made sure it was there. The
>>> order may be indeed off though.
>> 
>> Yes the order is wrong. The first SoB should be the commit author.
> 
> One optoin is to just land the original patch:
> https://lore.kernel.org/all/20250904-clk-send-sync-v1-1-48d023320eb8@google.com/
> 
> Alice

I guess this makes even more sense. I was hoping to land these two together,
but clearly this will not be possible for the time being as the second patch
has no r-b tags.

— Daniel