linux-kernel - Re: [PATCH 1/5] arm64: dts: qcom: r0q: add gpio keys

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3sox7jdjpahljevgyctg7zbvoua364hyajbap3ulsykloxqzna@dl2lfxdppdba>
Date: Sun, 21 Sep 2025 02:21:19 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Eric Gonçalves <ghatto404@...il.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley <conor+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/5] arm64: dts: qcom: r0q: add gpio keys

On Sat, Sep 20, 2025 at 05:22:28PM -0300, Eric Gonçalves wrote:
> 
> 
> On September 20, 2025 5:15:41 PM GMT-03:00, Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com> wrote:
> >On Sat, Sep 20, 2025 at 03:02:42PM -0300, Eric Gonçalves wrote:
> >> 
> >> 
> >> On September 20, 2025 12:45:27 PM GMT-03:00, Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com> wrote:
> >> >On Sat, Sep 20, 2025 at 01:46:33AM +0000, Eric Gonçalves wrote:
> >> >> Add GPIO keys support to Samsung Galaxy S22 (r0q).
> >> >> 
> >> >> Signed-off-by: Eric Gonçalves <ghatto404@...il.com>
> >> >> ---
> >> >>  .../boot/dts/qcom/sm8450-samsung-r0q.dts      | 53 +++++++++++++++----
> >> >>  1 file changed, 44 insertions(+), 9 deletions(-)
> >> >> 
> >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts b/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
> >> >> index 880d74ae6032..70e953824996 100644
> >> >> --- a/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
> >> >> +++ b/arch/arm64/boot/dts/qcom/sm8450-samsung-r0q.dts
> >> >> @@ -2,11 +2,12 @@
> >> >>  
> >> >>  /dts-v1/;
> >> >>  
> >> >> +#include <dt-bindings/input/linux-event-codes.h>
> >> >>  #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> >> >> -
> >> >>  #include "sm8450.dtsi"
> >> >>  #include "pm8350.dtsi"
> >> >>  #include "pm8350c.dtsi"
> >> >> +#include "pmk8350.dtsi"
> >> >>  
> >> >>  / {
> >> >>  	model = "Samsung Galaxy S22 5G";
> >> >> @@ -28,13 +29,19 @@ framebuffer: framebuffer@...00000 {
> >> >>  		};
> >> >>  	};
> >> >>  
> >> >> -	vph_pwr: regulator-vph-pwr {
> >> >> -		compatible = "regulator-fixed";
> >> >> -		regulator-name = "vph_pwr";
> >> >> -		regulator-min-microvolt = <3700000>;
> >> >> -		regulator-max-microvolt = <3700000>;
> >> >> -		regulator-always-on;
> >> >> -		regulator-boot-on;
> >> >
> >> >Please don't mix up refactorings and new features. Split this patch into
> >> >several.
> >> The patch only added gpio-keys node and pon_resin,
> >> pon_pwrkey. Do you mean I have to split each button
> >> into separate patches?
> >
> >No. The patch also moves regulator-vph-pwr and changes the comment in
> >the TLMM node.
> >
> I thought they would be too small to be
> patches on their own. Is it okay if I split
> them into 2: arm64: dts: qcom: r0q: small refactor
> and arm64: dts: qcom: r0q: add gpio keys?

SGTM.

> >> >
> >> >> +	gpio-keys {
> >> >> +		compatible = "gpio-keys";
> >> >> +		autorepeat;
> >> >> +
> >> >> +		pinctrl-0 = <&vol_up_n>;
> >> >> +		pinctrl-names = "default";
> >> >> +
> >> >> +		key-vol-up {
> >> >> +			label = "Volume Up";
> >> >> +			linux,code = <KEY_VOLUMEUP>;
> >> >> +			gpios = <&pm8350_gpios 6 GPIO_ACTIVE_LOW>;
> >> >> +			debounce-interval = <15>;
> >> >> +		};
> >> >>  	};
> >> >>  
> >> >>  	reserved-memory {
> >> >> @@ -47,6 +54,15 @@ splash-region@...00000 {
> >> >>  			no-map;
> >> >>  		};
> >> >>  	};
> >> >> +
> >> >> +	vph_pwr: regulator-vph-pwr {
> >> >> +		compatible = "regulator-fixed";
> >> >> +		regulator-name = "vph_pwr";
> >> >> +		regulator-min-microvolt = <3700000>;
> >> >> +		regulator-max-microvolt = <3700000>;
> >> >> +		regulator-always-on;
> >> >> +		regulator-boot-on;
> >> >> +	};
> >> >>  };
> >> >>  
> >> >>  &apps_rsc {
> >> >> @@ -119,8 +135,27 @@ vreg_l1c_1p8: ldo1 {
> >> >>  	};
> >> >>  };
> >> >>  
> >> >> +&pm8350_gpios {
> >> >> +	vol_up_n: vol-up-n-state {
> >> >> +		pins = "gpio6";
> >> >> +		function = "normal";
> >> >> +		power-source = <1>;
> >> >> +		input-enable;
> >> >> +	};
> >> >> +};
> >> >> +
> >> >> +&pon_pwrkey {
> >> >> +	status = "okay";
> >> >> +};
> >> >> +
> >> >> +&pon_resin {
> >> >> +	linux,code = <KEY_VOLUMEDOWN>;
> >> >> +
> >> >> +	status = "okay";
> >> >> +};
> >> >> +
> >> >>  &tlmm {
> >> >> -	gpio-reserved-ranges = <36 4>; /* SPI (not linked to anything) */
> >> >> +	gpio-reserved-ranges = <36 4>; /* SPI (Unused) */
> >> >>  };
> >> >>  
> >> >>  &usb_1 {
> >> >> -- 
> >> >> 2.51.0
> >> >> 
> >> >
> >> Resend because I forgot to CC the mailing lists
> >

-- 
With best wishes
Dmitry