linux-kernel - Re: [PATCH v2] asm-generic: Remove pud

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d9f45fdb-4ecd-23b0-6c98-846be24976aa@kernel.org>
Date: Fri, 19 Sep 2025 18:14:34 -0600 (MDT)
From: Paul Walmsley <pjw@...nel.org>
To: Christophe Leroy <christophe.leroy@...roup.eu>
cc: Arnd Bergmann <arnd@...db.de>, linux-arch@...r.kernel.org, 
    Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org, 
    linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
    linux-riscv@...ts.infradead.org, Catalin Marinas <catalin.marinas@....com>, 
    Will Deacon <will@...nel.org>, Paul Walmsley <paul.walmsley@...ive.com>, 
    Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>, 
    Alexandre Ghiti <alex@...ti.fr>, Peter Xu <peterx@...hat.com>, 
    Oscar Salvador <osalvador@...e.de>, 
    Alexandre Ghiti <alexghiti@...osinc.com>
Subject: Re: [PATCH v2] asm-generic: Remove pud_user() from pgtable-nopmd.h

On Mon, 18 Aug 2025, Christophe Leroy wrote:

> Commit 2c8a81dc0cc5 ("riscv/mm: fix two page table check related
> issues") added pud_user() in include/asm-generic/pgtable-nopmd.h
> 
> But pud_user() only exists on ARM64 and RISCV and is not expected
> by any part of MM.
> 
> Add the missing definition in arch/riscv/include/asm/pgtable-32.h
> and remove it from asm-generic/pgtable-nopmd.h
> 
> A stub pud_user() is also required for ARM64 after
> commit ed928a3402d8 ("arm64/mm: fix page table check compile
> error for CONFIG_PGTABLE_LEVELS=2")
> 
> Signed-off-by: Christophe Leroy <christophe.leroy@...roup.eu>
> Reviewed-by: Peter Xu <peterx@...hat.com>
> Reviewed-by: Oscar Salvador <osalvador@...e.de>
> Acked-by: Alexandre Ghiti <alexghiti@...osinc.com> # riscv
> Acked-by: Catalin Marinas <catalin.marinas@....com>

Acked-by: Paul Walmsley <pjw@...nel.org> # riscv


- Paul