linux-kernel - Re: [PATCH] rtc: tegra: Add ACPI support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202509200953.uZOl24Is-lkp@intel.com>
Date: Sat, 20 Sep 2025 10:09:13 +0800
From: kernel test robot <lkp@...el.com>
To: Kartik Rajput <kkartik@...dia.com>, alexandre.belloni@...tlin.com,
	thierry.reding@...il.com, jonathanh@...dia.com,
	andriy.shevchenko@...ux.intel.com, linux-rtc@...r.kernel.org,
	linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, Kartik Rajput <kkartik@...dia.com>
Subject: Re: [PATCH] rtc: tegra: Add ACPI support

Hi Kartik,

kernel test robot noticed the following build errors:

[auto build test ERROR on tegra/for-next]
[also build test ERROR on abelloni/rtc-next linus/master v6.17-rc6 next-20250919]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Kartik-Rajput/rtc-tegra-Add-ACPI-support/20250919-191553
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tegra/linux.git for-next
patch link:    https://lore.kernel.org/r/20250919111232.605405-1-kkartik%40nvidia.com
patch subject: [PATCH] rtc: tegra: Add ACPI support
config: arm-randconfig-001-20250920 (https://download.01.org/0day-ci/archive/20250920/202509200953.uZOl24Is-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 12.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250920/202509200953.uZOl24Is-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202509200953.uZOl24Is-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/rtc/rtc-tegra.c: In function 'tegra_rtc_probe':
>> drivers/rtc/rtc-tegra.c:310:13: error: implicit declaration of function 'is_of_node'; did you mean 'dev_of_node'? [-Werror=implicit-function-declaration]
     310 |         if (is_of_node(dev_fwnode(&pdev->dev))) {
         |             ^~~~~~~~~~
         |             dev_of_node
   cc1: some warnings being treated as errors


vim +310 drivers/rtc/rtc-tegra.c

   283	
   284	static int tegra_rtc_probe(struct platform_device *pdev)
   285	{
   286		struct tegra_rtc_info *info;
   287		int ret;
   288	
   289		info = devm_kzalloc(&pdev->dev, sizeof(*info), GFP_KERNEL);
   290		if (!info)
   291			return -ENOMEM;
   292	
   293		info->base = devm_platform_ioremap_resource(pdev, 0);
   294		if (IS_ERR(info->base))
   295			return PTR_ERR(info->base);
   296	
   297		ret = platform_get_irq(pdev, 0);
   298		if (ret <= 0)
   299			return ret;
   300	
   301		info->irq = ret;
   302	
   303		info->rtc = devm_rtc_allocate_device(&pdev->dev);
   304		if (IS_ERR(info->rtc))
   305			return PTR_ERR(info->rtc);
   306	
   307		info->rtc->ops = &tegra_rtc_ops;
   308		info->rtc->range_max = U32_MAX;
   309	
 > 310		if (is_of_node(dev_fwnode(&pdev->dev))) {
   311			info->clk = devm_clk_get(&pdev->dev, NULL);
   312			if (IS_ERR(info->clk))
   313				return PTR_ERR(info->clk);
   314	
   315			ret = clk_prepare_enable(info->clk);
   316			if (ret < 0)
   317				return ret;
   318		}
   319	
   320		/* set context info */
   321		info->pdev = pdev;
   322		spin_lock_init(&info->lock);
   323	
   324		platform_set_drvdata(pdev, info);
   325	
   326		/* clear out the hardware */
   327		writel(0, info->base + TEGRA_RTC_REG_SECONDS_ALARM0);
   328		writel(0xffffffff, info->base + TEGRA_RTC_REG_INTR_STATUS);
   329		writel(0, info->base + TEGRA_RTC_REG_INTR_MASK);
   330	
   331		device_init_wakeup(&pdev->dev, true);
   332	
   333		ret = devm_request_irq(&pdev->dev, info->irq, tegra_rtc_irq_handler,
   334				       IRQF_TRIGGER_HIGH, dev_name(&pdev->dev),
   335				       &pdev->dev);
   336		if (ret) {
   337			dev_err(&pdev->dev, "failed to request interrupt: %d\n", ret);
   338			goto disable_clk;
   339		}
   340	
   341		ret = devm_rtc_register_device(info->rtc);
   342		if (ret)
   343			goto disable_clk;
   344	
   345		dev_notice(&pdev->dev, "Tegra internal Real Time Clock\n");
   346	
   347		return 0;
   348	
   349	disable_clk:
   350		if (is_of_node(dev_fwnode(&pdev->dev)))
   351			clk_disable_unprepare(info->clk);
   352		return ret;
   353	}
   354	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki