linux-kernel - Re: [PATCH 2/2] arm64: dts: mediatek: mt7981b: OpenWrt One: set console UART to 115200

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aM4TQc32cNYY-wLA@pidgin.makrotopia.org>
Date: Sat, 20 Sep 2025 03:36:49 +0100
From: Daniel Golle <daniel@...rotopia.org>
To: bryan@...anhinton.com
Cc: devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
	angelogioacchino.delregno@...labora.com, conor+dt@...nel.org,
	krzk+dt@...nel.org, matthias.bgg@...il.com, robh@...nel.org
Subject: Re: [PATCH 2/2] arm64: dts: mediatek: mt7981b: OpenWrt One: set
 console UART to 115200

On Fri, Sep 19, 2025 at 07:06:12PM -0500, bryan@...anhinton.com wrote:
> Use the new uart0 label for the console and make the speed explicit by
> adding current-speed = <115200>. This keeps the DTS OS-agnostic: no
> bootargs or distribution-specific properties are added.
> 
> Verification: Boot-tested with mainline Image+DTB via U-Boot on OpenWrt
> One (MT7981B). Serial console active at 115200 baud, and DTB decompile
> confirms serial0 alias and stdout-path set correctly.
> 
> Signed-off-by: Bryan Hinton <bryan@...anhinton.com>

Reviewed-by: Daniel Golle <daniel@...rotopia.org>

See comment below
> ---
>  .../arm64/boot/dts/mediatek/mt7981b-openwrt-one.dts | 13 +++++++++++++
>  1 file changed, 13 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/mediatek/mt7981b-openwrt-one.dts b/arch/arm64/boot/dts/mediatek/mt7981b-openwrt-one.dts
> index 4f6cbb491287..1d2c3a21019c 100644
> --- a/arch/arm64/boot/dts/mediatek/mt7981b-openwrt-one.dts
> +++ b/arch/arm64/boot/dts/mediatek/mt7981b-openwrt-one.dts
> @@ -8,8 +8,21 @@ / {
>  	compatible = "openwrt,one", "mediatek,mt7981b";
>  	model = "OpenWrt One";
>  
> +	aliases {
> +		serial0 = &uart0;
> +	};
> +
> +	chosen {
> +		stdout-path = "serial0:115200n8";
> +	};
> +
>  	memory@...00000 {
>  		reg = <0 0x40000000 0 0x40000000>;
>  		device_type = "memory";
>  	};
>  };
> +
> +&uart0 {
> +	status = "okay";
> +	current-speed = <115200>; /* 0x1c200 */

The comment with the hex value should be removed. There is no need for it.

> +};
> -- 
> 2.51.0
> 
>