linux-kernel - Re: [PATCH] selftests/timers: Skip some posix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87o6r46xsw.ffs@tglx>
Date: Sun, 21 Sep 2025 09:59:27 +0200
From: Thomas Gleixner <tglx@...utronix.de>
To: Wake Liu <wakel@...gle.com>, John Stultz <jstultz@...gle.com>,
 Anna-Maria Behnsen <anna-maria@...utronix.de>, Frederic Weisbecker
 <frederic@...nel.org>, Shuah Khan <shuah@...nel.org>
Cc: Stephen Boyd <sboyd@...nel.org>, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, wakel@...gle.com
Subject: Re: [PATCH] selftests/timers: Skip some posix_timers tests on
 kernels < 6.13

On Thu, Aug 07 2025 at 16:50, Wake Liu wrote:
> Several tests in the posix_timers selftest fail on kernels older
> than 6.13. These tests check for timer behavior related to SIG_IGN,
> which was refactored in the 6.13 kernel cycle, notably by
> commit caf77435dd8a ("signal: Handle ignored signals in
> do_sigaction(action != SIG_IGN)").
>
> To ensure the selftests pass on older, stable kernels, gate the
> affected tests with a ksft_min_kernel_version(6, 13) check.

What's the point of emitting 9 times the same skip message?

There is no value at all and this can nicely be solved in main() by
checking the kernel version once, registering either 10 or 19 tests and
not invoking the tests which depend on 6.13+ in the first place, No?

Thanks,

        tglx