linux-kernel - Re: [PATCH net 0/3] broadcom: report the supported flags for ancillary features

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANz3_EZO_UJc4DodMRA721Ns523x-wJeUiTuOTiNu2SrhwcgEg@mail.gmail.com>
Date: Sun, 21 Sep 2025 08:26:55 +0700
From: James Clark <jjc@...ark.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Jacob Keller <jacob.e.keller@...el.com>, 
	Florian Fainelli <florian.fainelli@...adcom.com>, 
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>, Andrew Lunn <andrew@...n.ch>, 
	Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, 
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Paolo Abeni <pabeni@...hat.com>, Vadim Fedorenko <vadim.fedorenko@...ux.dev>, 
	Kory Maincent <kory.maincent@...tlin.com>, Richard Cochran <richardcochran@...il.com>, 
	Yaroslav Kolomiiets <yrk@...a.com>, netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net 0/3] broadcom: report the supported flags for
 ancillary features

On Sat, Sep 20, 2025 at 7:04 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Thu, 18 Sep 2025 17:33:15 -0700 Jacob Keller wrote:
> > James Clark reported off list that the broadcom PHY PTP driver was
> > incorrectly handling PTP_EXTTS_REQUEST and PTP_PEROUT_REQUEST ioctls since
> > the conversion to the .supported_*_flags fields. This series fixes the
> > driver to correctly report its flags through the .supported_perout_flags
> > and .supported_extts_flags fields. It also contains an update to comment
> > the behavior of the PTP_STRICT_FLAGS being always enabled for
> > PTP_EXTTS_REQUEST2.
>
> James, would you be willing to test and send an official Tested-by tag?

I have tested this on a Raspberry Pi CM4: PTP_EXTTS_REQUEST2 and
PTP_PEROUT_REQUEST2 both work. Thanks!

Going forward, I have got myself setup to be able to build and install
a vanilla kernel on a CM4, so if there is stuff that needs testing on
bcm-phy-ptp, just Cc me.

Tested-by: James Clark <jjc@...ark.com>