linux-kernel - Re: [PATCH v2 11/25] genirq: Kill handle_percpu_devid_fasteoi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87o6r3yg75.wl-maz@kernel.org>
Date: Sun, 21 Sep 2025 16:32:14 +0100
From: Marc Zyngier <maz@...nel.org>
To: Jonathan Cameron <jonathan.cameron@...wei.com>
Cc: <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>,
	<linux-acpi@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	"Mark\
 Rutland" <mark.rutland@....com>,
	Will Deacon <will@...nel.org>,
	"Rafael J.\
 Wysocki" <rafael@...nel.org>,
	Rob Herring <robh@...nel.org>,
	"Saravana\
 Kannan" <saravanak@...gle.com>,
	Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>,
	Sven Peter <sven@...nel.org>,
	Janne Grunau
	<j@...nau.net>,
	Suzuki K Poulose <suzuki.poulose@....com>,
	James Clark
	<james.clark@...aro.org>
Subject: Re: [PATCH v2 11/25] genirq: Kill handle_percpu_devid_fasteoi_nmi()

On Tue, 16 Sep 2025 16:38:38 +0100,
Jonathan Cameron <jonathan.cameron@...wei.com> wrote:
> 
> On Mon, 15 Sep 2025 09:56:48 +0100
> Marc Zyngier <maz@...nel.org> wrote:
> 
> > There is no in-tree user of this flow handler anymore, so simply
> > remove it.
> > 
> > Suggested-by: Will Deacon <will@...nel.org>
> > Signed-off-by: Marc Zyngier <maz@...nel.org>
> > ---
> 
> > diff --git a/kernel/irq/chip.c b/kernel/irq/chip.c
> > index 0d0276378c707..869068ec6ac91 100644
> > --- a/kernel/irq/chip.c
> > +++ b/kernel/irq/chip.c
> > @@ -892,7 +892,8 @@ void handle_percpu_irq(struct irq_desc *desc)
> >   *
> >   * action->percpu_dev_id is a pointer to percpu variables which
> >   * contain the real device id for the cpu on which this handler is
> > - * called
> > + * called. This is also used for per-CPU NMIs, so special care is
> > + * required.
> 
> Probably belongs in previous patch as not really related to removing
> the unused code, but meh.

Actually, I think I'll simply drop this comment. It really doesn't
bring much to the table.

Thanks,

	M.

-- 
Jazz isn't dead. It just smells funny.