linux-kernel - Re: [PATCH v3 06/11] clk: tegra: remove EMC to MC clock mux in Tegra114

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <175847725338.4354.4145979844570539358@lazor>
Date: Sun, 21 Sep 2025 10:54:13 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Chanwoo Choi <cw00.choi@...sung.com>, Conor Dooley <conor+dt@...nel.org>, Dmitry Osipenko <digetx@...il.com>, Jonathan Hunter <jonathanh@...dia.com>, Krzysztof Kozlowski <krzk@...nel.org>, Kyungmin Park <kyungmin.park@...sung.com>, Michael Turquette <mturquette@...libre.com>, Mikko Perttunen <mperttunen@...dia.com>, MyungJoo Ham <myungjoo.ham@...sung.com>, Prashant Gaikwad <pgaikwad@...dia.com>, Rob Herring <robh@...nel.org>, Svyatoslav Ryhel <clamor95@...il.com>, Thierry Reding <thierry.reding@...il.com>, Thierry Reding <treding@...dia.com>
Cc: linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, linux-tegra@...r.kernel.org, linux-clk@...r.kernel.org, linux-pm@...r.kernel.org
Subject: Re: [PATCH v3 06/11] clk: tegra: remove EMC to MC clock mux in Tegra114

Quoting Svyatoslav Ryhel (2025-09-15 01:01:52)
> diff --git a/drivers/clk/tegra/clk-tegra114.c b/drivers/clk/tegra/clk-tegra114.c
> index 8bde72aa5e68..6b3a140772c2 100644
> --- a/drivers/clk/tegra/clk-tegra114.c
> +++ b/drivers/clk/tegra/clk-tegra114.c
> @@ -1321,6 +1309,28 @@ static int tegra114_reset_deassert(unsigned long id)
>         return 0;
>  }
>  
> +#ifdef CONFIG_TEGRA124_CLK_EMC
> +static struct clk *tegra114_clk_src_onecell_get(struct of_phandle_args *clkspec,
> +                                               void *data)
> +{
> +       struct clk_hw *hw;
> +       struct clk *clk;
> +
> +       clk = of_clk_src_onecell_get(clkspec, data);
> +       if (IS_ERR(clk))
> +               return clk;
> +
> +       hw = __clk_get_hw(clk);

Can you just use of_clk_hw_onecell_get() instead? Then we don't need to
use __clk_get_hw(). Or is this whole function used to return a clk
pointer to something that isn't the clk framework?

> +
> +       if (clkspec->args[0] == TEGRA114_CLK_EMC) {
> +               if (!tegra124_clk_emc_driver_available(hw))
> +                       return ERR_PTR(-EPROBE_DEFER);
> +       }
> +
> +       return clk;