linux-kernel - Re: [PATCH v5] clk: socfpga: agilex: add support for the Intel Agilex5

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <175847759120.4354.5284082297601743277@lazor>
Date: Sun, 21 Sep 2025 10:59:51 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Matthew Gerlach <matthew.gerlach@...era.com>, dinguyen@...nel.org, linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org, mturquette@...libre.com, netdev@...r.kernel.org, richardcochran@...il.com
Cc: Niravkumar L Rabara <niravkumar.l.rabara@...el.com>, Teh Wen Ping <wen.ping.teh@...el.com>
Subject: Re: [PATCH v5] clk: socfpga: agilex: add support for the Intel Agilex5

Quoting Matthew Gerlach (2025-07-02 09:04:17)
> On 6/30/25 6:05 PM, Stephen Boyd wrote:
> > Quoting Matthew Gerlach (2025-05-13 16:48:37)
> > > @@ -334,6 +336,375 @@ static const struct stratix10_gate_clock agilex_gate_clks[] = {
> > >           10, 0, 0, 0, 0, 0, 4},
> > >  };
> > >  
> > > +static const struct clk_parent_data agilex5_pll_mux[] = {
> > > +       { .name = "osc1", },
> > > +       { .name = "cb-intosc-hs-div2-clk", },
> > > +       { .name = "f2s-free-clk", },
> >
> > Please don't use clk_parent_data with only .name set with dot
> > initializers. This is actually { .index = 0, .name = "..." } which means
> > the core is looking at the DT node for the first index of the 'clocks'
> If the core should be looking for the first index of the 'clocks' 
> property, is it better to explicitly to state ".index = 0" or just have 
> the name?

Be explicit with '.index = 0' and don't have a '.name' member.