linux-kernel - [PATCH 3/4] drm/mipi-dsi: remove deprecated mipi_dsi_dcs_write_buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250921183720.237761-6-rtapadia730@gmail.com>
Date: Mon, 22 Sep 2025 00:07:22 +0530
From: rtapadia730@...il.com
To: neil.armstrong@...aro.org,
	maarten.lankhorst@...ux.intel.com
Cc: mripard@...nel.org,
	tzimmermann@...e.de,
	airlied@...il.com,
	simona@...ll.ch,
	jessica.zhang@....qualcomm.com,
	dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org,
	linux-doc@...r.kernel.org,
	corbet@....net,
	Rajeev Tapadia <rtapadia730@...il.com>
Subject: [PATCH 3/4] drm/mipi-dsi: remove deprecated mipi_dsi_dcs_write_buffer_chatty

From: Rajeev Tapadia <rtapadia730@...il.com>

The mipi_dsi_dcs_write_buffer_chatty() helper is redundant and
non-intuitive. It has been removed in favour of
mipi_dsi_dcs_write_buffer_multi(), which handles multiple DSI writes with
proper error accumulation.

Signed-off-by: Rajeev Tapadia <rtapadia730@...il.com>
---
 drivers/gpu/drm/drm_mipi_dsi.c | 32 ++------------------------------
 include/drm/drm_mipi_dsi.h     |  2 --
 2 files changed, 2 insertions(+), 32 deletions(-)

diff --git a/drivers/gpu/drm/drm_mipi_dsi.c b/drivers/gpu/drm/drm_mipi_dsi.c
index bc847ab5c822..c2fcc219cb58 100644
--- a/drivers/gpu/drm/drm_mipi_dsi.c
+++ b/drivers/gpu/drm/drm_mipi_dsi.c
@@ -926,40 +926,12 @@ ssize_t mipi_dsi_dcs_write_buffer(struct mipi_dsi_device *dsi,
 EXPORT_SYMBOL(mipi_dsi_dcs_write_buffer);
 
 /**
- * mipi_dsi_dcs_write_buffer_chatty - mipi_dsi_dcs_write_buffer() w/ an error log
- * @dsi: DSI peripheral device
- * @data: buffer containing data to be transmitted
- * @len: size of transmission buffer
- *
- * Like mipi_dsi_dcs_write_buffer() but includes a dev_err()
- * call for you and returns 0 upon success, not the number of bytes sent.
- *
- * Return: 0 on success or a negative error code on failure.
- */
-int mipi_dsi_dcs_write_buffer_chatty(struct mipi_dsi_device *dsi,
-				     const void *data, size_t len)
-{
-	struct device *dev = &dsi->dev;
-	ssize_t ret;
-
-	ret = mipi_dsi_dcs_write_buffer(dsi, data, len);
-	if (ret < 0) {
-		dev_err(dev, "sending dcs data %*ph failed: %zd\n",
-			(int)len, data, ret);
-		return ret;
-	}
-
-	return 0;
-}
-EXPORT_SYMBOL(mipi_dsi_dcs_write_buffer_chatty);
-
-/**
- * mipi_dsi_dcs_write_buffer_multi - mipi_dsi_dcs_write_buffer_chatty() w/ accum_err
+ * mipi_dsi_dcs_write_buffer_multi - mipi_dsi_dcs_write_buffer() w/ accum_err
  * @ctx: Context for multiple DSI transactions
  * @data: buffer containing data to be transmitted
  * @len: size of transmission buffer
  *
- * Like mipi_dsi_dcs_write_buffer_chatty() but deals with errors in a way that
+ * Like mipi_dsi_dcs_write_buffer() but deals with errors in a way that
  * makes it convenient to make several calls in a row.
  */
 void mipi_dsi_dcs_write_buffer_multi(struct mipi_dsi_multi_context *ctx,
diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h
index e4d26ed7a62a..cda981a41bc6 100644
--- a/include/drm/drm_mipi_dsi.h
+++ b/include/drm/drm_mipi_dsi.h
@@ -326,8 +326,6 @@ enum mipi_dsi_dcs_tear_mode {
 
 ssize_t mipi_dsi_dcs_write_buffer(struct mipi_dsi_device *dsi,
 				  const void *data, size_t len);
-int mipi_dsi_dcs_write_buffer_chatty(struct mipi_dsi_device *dsi,
-				     const void *data, size_t len);
 void mipi_dsi_dcs_write_buffer_multi(struct mipi_dsi_multi_context *ctx,
 				     const void *data, size_t len);
 ssize_t mipi_dsi_dcs_write(struct mipi_dsi_device *dsi, u8 cmd,
-- 
2.51.0

Test patch