linux-kernel - Re: [PATCH v11 1/3] dt-bindings: iio: adc: add max14001

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250921-paralegal-styling-17b66d975dcf@spud>
Date: Sun, 21 Sep 2025 22:22:11 +0100
From: Conor Dooley <conor@...nel.org>
To: Marcelo Schmitt <marcelo.schmitt1@...il.com>
Cc: David Lechner <dlechner@...libre.com>,
	Marilene Andrade Garcia <marilene.agarcia@...il.com>,
	linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org,
	devicetree@...r.kernel.org,
	Kim Seer Paller <kimseer.paller@...log.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Jonathan Cameron <jic23@...nel.org>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Marcelo Schmitt <Marcelo.Schmitt@...log.com>,
	Ceclan Dumitru <dumitru.ceclan@...log.com>,
	Jonathan Santos <Jonathan.Santos@...log.com>,
	Dragos Bogdan <dragos.bogdan@...log.com>
Subject: Re: [PATCH v11 1/3] dt-bindings: iio: adc: add max14001

On Sat, Sep 20, 2025 at 06:44:52PM -0300, Marcelo Schmitt wrote:
> ...
> > 
> > > > +  interrupts:
> > > > +    minItems: 1
> > > > +    items:
> > > > +      - description: |
> > > > +          Asserts high when ADC readings exceed the upper threshold and low
> > > > +          when below the lower threshold. Must be connected to the COUT pin.
> > > > +      - description: |
> > > > +          Alert output that asserts low during a number of different error
> > > > +          conditions. The interrupt source must be attached to FAULT pin.
> > 
> > These descriptions read wrong to me. They __are__ the COUT and FAULT
> > pins, given what David responded to above, not something that can be
> > connected to these pins (if they were, they would be represented as
> > -gpios rather than interrupts most likely). Unless you mean that these
> > pins can have some other use and are only available on the COUT/FAULT
> > pins when some register value is set - but even in that case saying
> > "must be" doesn't fit since the interrupt property could be used to
> > configure the device accordingly.
> 
> COUT and FAULT are just two pins on the ADC chip that can be used to generate
> interrupts. Would a description like the one below sound better?
> 
>   interrupts:
>     minItems: 1
>     items:
>       - description: |
>           cout: Comparator output signal that asserts high when ADC readings
>           exceed the upper threshold and low when readings fall below the lower
>           threshold.

I think you should mention the pin name here, like you did below.
"asserts high on the COUT pin" or w/e.

>       - description: |
>           fault: When fault reporting is enabled, the FAULT pin is asserted low
>           whenever one of the monitored fault conditions occurs.
> 
> Best regards,
> Marcelo

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)