[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <175843192257.42245.2136343963364128168.b4-ty@kernel.dk>
Date: Sat, 20 Sep 2025 23:18:42 -0600
From: Jens Axboe <axboe@...nel.dk>
To: Mohit Gupta <mgupta@...estorage.com>,
Caleb Sander Mateos <csander@...estorage.com>,
Ming Lei <ming.lei@...hat.com>, Shuah Khan <shuah@...nel.org>,
Uday Shankar <ushankar@...estorage.com>
Cc: linux-block@...r.kernel.org, linux-kselftest@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] selftests: ublk: fix behavior when fio is not
installed
On Tue, 16 Sep 2025 18:42:52 -0600, Uday Shankar wrote:
> Some ublk selftests have strange behavior when fio is not installed.
> While most tests behave correctly (run if they don't need fio, or skip
> if they need fio), the following tests have different behavior:
>
> - test_null_01, test_null_02, test_generic_01, test_generic_02, and
> test_generic_12 try to run fio without checking if it exists first,
> and fail on any failure of the fio command (including "fio command
> not found"). So these tests fail when they should skip.
> - test_stress_05 runs fio without checking if it exists first, but
> doesn't fail on fio command failure. This test passes, but that pass
> is misleading as the test doesn't do anything useful without fio
> installed. So this test passes when it should skip.
>
> [...]
Applied, thanks!
[1/1] selftests: ublk: fix behavior when fio is not installed
commit: a3835a44107fcbf05f183b5e8b60a8e4605b15ea
Best regards,
--
Jens Axboe
Powered by blists - more mailing lists