linux-kernel - Re: [PATCH 2/4] dt-bindings: sound: Update ADMAIF bindings for tegra264

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250922173150.GA506813-robh@kernel.org>
Date: Mon, 22 Sep 2025 12:31:50 -0500
From: Rob Herring <robh@...nel.org>
To: "Sheetal ." <sheetal@...dia.com>
Cc: Vinod Koul <vkoul@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Marc Zyngier <maz@...nel.org>, Thomas Gleixner <tglx@...utronix.de>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>,
	Jonathan Hunter <jonathanh@...dia.com>,
	Sameer Pujar <spujar@...dia.com>, dmaengine@...r.kernel.org,
	devicetree@...r.kernel.org, linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-sound@...r.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: sound: Update ADMAIF bindings for
 tegra264

On Thu, Sep 18, 2025 at 03:50:07PM +0530, Sheetal . wrote:
> From: sheetal <sheetal@...dia.com>
> 
> Update the ADMAIF bindings as tegra264 supports 64 channels, which includes
> 32 RX and 32 TX channels.
> 
> Signed-off-by: sheetal <sheetal@...dia.com>
> ---
>  .../sound/nvidia,tegra210-admaif.yaml         | 49 +++++++++++++------
>  1 file changed, 35 insertions(+), 14 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml b/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml
> index b32f33214ba6..f53ecef379b3 100644
> --- a/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml
> +++ b/Documentation/devicetree/bindings/sound/nvidia,tegra210-admaif.yaml
> @@ -93,20 +93,41 @@ then:
>      iommus: false
>  
>  else:
> -  properties:
> -    dmas:
> -      description:
> -        DMA channel specifiers, equally divided for Tx and Rx.
> -      minItems: 1
> -      maxItems: 40
> -    dma-names:
> -      items:
> -        pattern: "^[rt]x(1[0-9]|[1-9]|20)$"
> -      description:
> -        Should be "rx1", "rx2" ... "rx20" for DMA Rx channel
> -        Should be "tx1", "tx2" ... "tx20" for DMA Tx channel
> -      minItems: 1
> -      maxItems: 40
> +  if:

Try to avoid nested if/then/else if possible and put independent if/then 
schemas under 'allOf'.

> +    properties:
> +      compatible:
> +        contains:
> +          const: nvidia,tegra264-admaif
> +  then:
> +    properties:
> +      dmas:
> +        description:
> +          DMA channel specifiers, equally divided for Tx and Rx.
> +        minItems: 1
> +        maxItems: 64
> +      dma-names:
> +        items:
> +          pattern: "^[rt]x(3[0-2]|[1-2][0-9]|[1-9])$"
> +        description:
> +          Should be "rx1", "rx2" ... "rx32" for DMA Rx channel
> +          Should be "tx1", "tx2" ... "tx32" for DMA Tx channel
> +        minItems: 1
> +        maxItems: 64
> +  else:
> +    properties:
> +      dmas:
> +        description:
> +          DMA channel specifiers, equally divided for Tx and Rx.
> +        minItems: 1
> +        maxItems: 40
> +      dma-names:
> +        items:
> +          pattern: "^[rt]x(1[0-9]|[1-9]|20)$"
> +        description:
> +          Should be "rx1", "rx2" ... "rx20" for DMA Rx channel
> +          Should be "tx1", "tx2" ... "tx20" for DMA Tx channel
> +        minItems: 1
> +        maxItems: 40
>  
>  required:
>    - compatible
> -- 
> 2.34.1
>