linux-kernel - Re: [PATCH v2 07/10] gpu: nova-core: gsp: Create RM registry and sysinfo commands

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d87bff0c64fb2a549920354c8b09f764e145a492.camel@nvidia.com>
Date: Mon, 22 Sep 2025 19:10:52 +0000
From: Timur Tabi <ttabi@...dia.com>
To: "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
	Alistair Popple <apopple@...dia.com>, Alexandre Courbot
	<acourbot@...dia.com>, "dakr@...nel.org" <dakr@...nel.org>,
	"rust-for-linux@...r.kernel.org" <rust-for-linux@...r.kernel.org>
CC: "lossin@...nel.org" <lossin@...nel.org>, "ojeda@...nel.org"
	<ojeda@...nel.org>, "boqun.feng@...il.com" <boqun.feng@...il.com>,
	"a.hindborg@...nel.org" <a.hindborg@...nel.org>, "tzimmermann@...e.de"
	<tzimmermann@...e.de>, "tmgross@...ch.edu" <tmgross@...ch.edu>,
	"alex.gaynor@...il.com" <alex.gaynor@...il.com>, "simona@...ll.ch"
	<simona@...ll.ch>, "mripard@...nel.org" <mripard@...nel.org>,
	"maarten.lankhorst@...ux.intel.com" <maarten.lankhorst@...ux.intel.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, John Hubbard
	<jhubbard@...dia.com>, "nouveau@...ts.freedesktop.org"
	<nouveau@...ts.freedesktop.org>, "bjorn3_gh@...tonmail.com"
	<bjorn3_gh@...tonmail.com>, "airlied@...il.com" <airlied@...il.com>,
	"aliceryhl@...gle.com" <aliceryhl@...gle.com>, Joel Fernandes
	<joelagnelf@...dia.com>, "gary@...yguo.net" <gary@...yguo.net>
Subject: Re: [PATCH v2 07/10] gpu: nova-core: gsp: Create RM registry and
 sysinfo commands

On Mon, 2025-09-22 at 21:30 +1000, Alistair Popple wrote:


> +const GSP_REGISTRY_NUM_ENTRIES: usize = 2;
> +struct RegistryEntry {
> +    key: &'static str,
> +    value: u32,
> +}

Probably should add a comment saying that although GSP-RM technically supports strings as values, we
don't intend to use that feature.  You just have REGISTRY_TABLE_ENTRY_TYPE_DWORD defined without any
explanation that there are other entry types.  

Maybe REGISTRY_TABLE_ENTRY_TYPE_DWORD should be an enum instead of a const.

> +pub(crate) fn build_registry(cmdq: &mut GspCmdq, bar: &Bar0) -> Result {
> +    let registry = RegistryTable {
> +        entries: [
> +            RegistryEntry {
> +                key: "RMSecBusResetEnable",
> +                value: 1,
> +            },
> +            RegistryEntry {
> +                key: "RMForcePcieConfigSave",
> +                value: 1,
> +            },
> +        ],
> +    };

You might want to add another field to RegistryEntry that adds documentation for each of these
files?  Nouveau documents them as comments.

Also, you're missing RMDevidCheckIgnore.  See
https://lore-kernel.gnuweeb.org/nouveau/c34ccc23-5550-4f26-af66-47979afd197e@kernel.org/T/