linux-kernel - Re: [PATCH v4 1/2] dt-bindings: media: i2c: ams,mira220: Add mira220 image sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250922203352.GA1278145-robh@kernel.org>
Date: Mon, 22 Sep 2025 15:33:52 -0500
From: Rob Herring <robh@...nel.org>
To: Philippe Baetens <philippebaetens@...il.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>, linux-media@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 1/2] dt-bindings: media: i2c: ams,mira220: Add mira220
 image sensor

On Sat, Sep 20, 2025 at 09:47:58PM +0200, Philippe Baetens wrote:
> Mira220 is a global shutter NIR-enhanced image sensor made by AMS.
> Driver is submitted in the next patch of this series and verified on
> a raspberry pi.
> 
> Signed-off-by: Philippe Baetens <philippebaetens@...il.com>
> ---
>  .../devicetree/bindings/media/i2c/ams,mira220.yaml | 108 +++++++++++++++++++++
>  MAINTAINERS                                        |   6 ++
>  2 files changed, 114 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/ams,mira220.yaml b/Documentation/devicetree/bindings/media/i2c/ams,mira220.yaml
> new file mode 100644
> index 000000000..ae4613d0d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/ams,mira220.yaml
> @@ -0,0 +1,108 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/ams,mira220.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ams 2.2 MP NIR enhanced global shutter image sensor

s/ams/AMS/

> +
> +maintainers:
> +  - Philippe Baetens <philippebaetens@...il.com>
> +
> +description: |-

Don't need '|' if no formatting to preserve.

> +  2.2 MP NIR enhanced global shutter image sensor designed for 2D and 3D
> +  consumer and industrial machine vision applications.

Is this a paragraph or just a odd line break? If a paragraph, add a 
blank line in between and use '>' modifier.

> +  Due to its small size, configurability and high sensitivity both
> +  in visual as well as NIR, the Mira220 is well suited for 2D and
> +  3D applications, which include Active Stereo Vision,
> +  Structured Light Vision for Robotics and AR/VR.

Wrap at 80 char.

> +
> +allOf:
> +  - $ref: /schemas/media/video-interface-devices.yaml#
> +
> +properties:
> +  compatible:
> +    const: ams,mira220
> +
> +  reg:
> +    description: I2C device address

Drop. That's every device.

> +    maxItems: 1
> +
> +  clocks:
> +    maxItems: 1
> +
> +  vdig-supply:
> +    description:
> +      Digital I/O voltage supply, 1.35 volts
> +
> +  vana-supply:
> +    description:
> +      Analog1 voltage supply, 2.8 volts
> +
> +  vddl-supply:
> +    description:
> +      Digital core voltage supply, 1.8 volts
> +
> +  reset-gpios:
> +    description: Sensor reset (XCLR) GPIO
> +    maxItems: 1
> +
> +  port:
> +    $ref: /schemas/graph.yaml#/$defs/port-base
> +    additionalProperties: false
> +    description:
> +      Video output port
> +
> +    properties:
> +      endpoint:
> +        $ref: /schemas/media/video-interfaces.yaml#
> +        unevaluatedProperties: false
> +
> +        properties:
> +          data-lanes:
> +            anyOf:

Don't need 'anyOf' with a single entry.

> +              - items:
> +                  - const: 1
> +                  - const: 2
> +
> +          clock-noncontinuous: true
> +
> +        required:
> +          - data-lanes
> +          - link-frequencies
> +
> +
> +required:
> +  - compatible
> +  - reg
> +  - clocks
> +  - vdig-supply
> +  - vana-supply
> +  - vddl-supply
> +  - port
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        mira220: camera-sensor@54 {
> +            compatible = "ams,mira220";
> +            reg = <0x54>;
> +            clocks = <&cam1_clk>;
> +            vana-supply = <&cam1_reg>;	/* 2.5v */
> +            vdig-supply = <&cam_dummy_reg>;	/* 1.8v */
> +            vddl-supply = <&cam_dummy_reg>;	/* 1.35v */
> +            port {
> +                mira220_ep: endpoint {
> +                    clock-lanes = <0>;
> +                    data-lanes = <1 2>;
> +                    link-frequencies = /bits/ 64 <750000000>;
> +                };
> +            };
> +        };
> +    };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index fe168477c..c179b931b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1350,6 +1350,12 @@ S:	Maintained
>  F:	Documentation/devicetree/bindings/iio/light/ams,as73211.yaml
>  F:	drivers/iio/light/as73211.c
>  
> +AMS MIRA220 DRIVER
> +M:	Philippe Baetens <philippebaetens@...il.com>
> +S:	Maintained
> +F:	Documentation/devicetree/bindings/media/i2c/ams,mira220.yaml
> +F:	drivers/media/i2c/mira220.c
> +
>  AMT (Automatic Multicast Tunneling)
>  M:	Taehee Yoo <ap420073@...il.com>
>  L:	netdev@...r.kernel.org
> 
> -- 
> 2.43.0
>