[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20250923-ps5-hid-fixes-v1-1-4b994c54e512@collabora.com>
Date: Tue, 23 Sep 2025 00:29:40 +0300
From: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
To: Roderick Colenbrander <roderick.colenbrander@...y.com>,
Jiri Kosina <jikos@...nel.org>, Benjamin Tissoires <bentiss@...nel.org>
Cc: kernel@...labora.com, linux-input@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: [PATCH 1/3] HID: playstation: Update SP preamp gain comment line
Adjusting speaker pre-amp gain to 0x2 indicates +6dB, hence update the
related comment line accordingly.
Suggested-by: Roderick Colenbrander <roderick.colenbrander@...y.com>
Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@...labora.com>
---
drivers/hid/hid-playstation.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-playstation.c b/drivers/hid/hid-playstation.c
index d2bee1a314b1b4697378d8472d3f65df5d2cf790..e03ab8a92bca9416787caceb4682be253efe54a2 100644
--- a/drivers/hid/hid-playstation.c
+++ b/drivers/hid/hid-playstation.c
@@ -1372,7 +1372,7 @@ static void dualsense_output_worker(struct work_struct *work)
*/
common->valid_flag0 |= DS_OUTPUT_VALID_FLAG0_SPEAKER_VOLUME_ENABLE;
common->speaker_volume = 0x64;
- /* Set SP preamp gain to ~30% */
+ /* Set SP preamp gain to +6dB */
common->valid_flag1 = DS_OUTPUT_VALID_FLAG1_AUDIO_CONTROL2_ENABLE;
common->audio_control2 =
FIELD_PREP(DS_OUTPUT_AUDIO_FLAGS2_SP_PREAMP_GAIN, 0x2);
--
2.51.0
Powered by blists - more mailing lists