linux-kernel - Re: [PATCH v5 3/4] kho: add support for preserving vmalloc allocations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250922143407.93e171f8b7c09eb21159a33e@linux-foundation.org>
Date: Mon, 22 Sep 2025 14:34:07 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Jason Gunthorpe <jgg@...dia.com>
Cc: Mike Rapoport <rppt@...nel.org>, Alexander Graf <graf@...zon.com>,
 Baoquan He <bhe@...hat.com>, Changyuan Lyu <changyuanl@...gle.com>, Chris
 Li <chrisl@...nel.org>, Pasha Tatashin <pasha.tatashin@...een.com>,
 Pratyush Yadav <pratyush@...nel.org>, kexec@...ts.infradead.org,
 linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 3/4] kho: add support for preserving vmalloc
 allocations

On Mon, 22 Sep 2025 10:19:48 -0300 Jason Gunthorpe <jgg@...dia.com> wrote:

> > +static void kho_vmalloc_free_chunks(struct kho_vmalloc *kho_vmalloc)
> > +{
> > +	struct kho_vmalloc_chunk *chunk = KHOSER_LOAD_PTR(kho_vmalloc->first);
> > +
> > +	while (chunk) {
> > +		struct kho_vmalloc_chunk *tmp = chunk;
> > +
> > +		kho_vmalloc_unpreserve_chunk(chunk);
> > +
> > +		chunk = KHOSER_LOAD_PTR(chunk->hdr.next);
> > +		kfree(tmp);
> 
> Shouldn't this be free_page()?

Or vfree()?

Not sure why this code works - I'll suspend the series from linux-next
for now.