linux-kernel - Re: [PATCH v5 3/4] kho: add support for preserving vmalloc allocations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250922160836.8d0dc984ff0986b3809c9ab0@linux-foundation.org>
Date: Mon, 22 Sep 2025 16:08:36 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: "yanjun.zhu" <yanjun.zhu@...ux.dev>
Cc: Mike Rapoport <rppt@...nel.org>, Alexander Graf <graf@...zon.com>,
 Baoquan He <bhe@...hat.com>, Changyuan Lyu <changyuanl@...gle.com>, Chris
 Li <chrisl@...nel.org>, Jason Gunthorpe <jgg@...dia.com>, Pasha Tatashin
 <pasha.tatashin@...een.com>, Pratyush Yadav <pratyush@...nel.org>,
 kexec@...ts.infradead.org, linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 3/4] kho: add support for preserving vmalloc
 allocations

On Mon, 22 Sep 2025 15:31:42 -0700 "yanjun.zhu" <yanjun.zhu@...ux.dev> wrote:

> > +int kho_preserve_vmalloc(void *ptr, struct kho_vmalloc *preservation)
> > +{
> > +	struct kho_vmalloc_chunk *chunk;
> > +	struct vm_struct *vm = find_vm_area(ptr);
> > +	unsigned int order, flags, nr_contig_pages;
> > +	unsigned int idx = 0;
> > +	int err;
> 
> This is a trivial issue. I’m not sure whether RCT (Reverse Christmas 
> Trees) is used in the Linux MM mailing list.

Not as far as I know.  Some like it.

If I was to have a preference I'd suggest that things be laid out in a
logical order rather than by column count.  Group like things together,
avoid use of unintialized storage in initializers(!).