linux-kernel - Re: [PATCH net-next v2 5/6] netconsole: resume previously deactivated target

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250922165057.70eefc6b@kernel.org>
Date: Mon, 22 Sep 2025 16:50:57 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Andre Carvalho <asantostc@...il.com>
Cc: Breno Leitao <leitao@...ian.org>, Andrew Lunn <andrew+netdev@...n.ch>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Shuah Khan
 <shuah@...nel.org>, Simon Horman <horms@...nel.org>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org
Subject: Re: [PATCH net-next v2 5/6] netconsole: resume previously
 deactivated target

On Sun, 21 Sep 2025 22:55:45 +0100 Andre Carvalho wrote:
> +		if (nt->state == STATE_DEACTIVATED && event == NETDEV_UP)
> +			maybe_resume_target(nt, dev);

This uses GFP_KERNEL

>  		netconsole_target_put(nt);
>  	}
>  	spin_unlock_irqrestore(&target_list_lock, flags);

And we're under a spin lock.

This gets hit in the selftest you're adding so please triple check 
the kernel config that you're testing with.